Alasdair McLeay

Results 213 comments of Alasdair McLeay

We have [one package per React component](https://github.com/govuk-react/govuk-react). There are reasons we don't want to maintain a list beyond maintenance/size of the list - we don't want these libraries in devDependencies...

On a side note, we previously worked around our publishing issue by maintaining the list in the root package.json ```json "@govuk-react/error-text": "*", "@govuk-react/file-upload": "*", "@govuk-react/grid-col": "*", "@govuk-react/grid-row": "*", "@govuk-react/header": "*",...

I released v0.1.0 of @govuk-react/icon-crown, but I think I'll need to do a new release of govuk-react with the updated dependency due to using a 0.0.x version previously 🤦 You...

Thanks for raising this. Looking at[ErrorSummary](https://github.com/govuk-react/govuk-react/blob/main/components/error-summary/src/index.tsx): ```tsx onHandleErrorClick?.(error.targetName)}> {error.text} ``` StyledErrorText is an anchor but is missing an href. Perhaps we need to add `href={onHandleErrorClick ? '#' : undefined} `:...

LGTM The `ComponentAnnotations.component` type is: ```ts component?: (TRenderer & { T: Record extends Required ? any : TArgs; })['component']; ``` So, as `Required` don't apply to subcomponents, changing subcomponents to...

3 changes shown up in Chromatic, relating to the Tabs component. All seem to be the same issue, namely that the "Contents" title is no longer showing: https://www.chromatic.com/component?appId=5ad61aab7f00090020dfdba8&csfId=tabs&specName=Simple%20With%20Map%20And%20Babel%20S%20Proposed%20Class%20Properties%20Plugin&buildNumber=2257

Just the one issue - thank you very much for the contribution :)