Alasdair McLeay

Results 200 comments of Alasdair McLeay

# Proposal for supporting link type For any link-like component, that we want the peer project to be able to configure to use a React Router Link or NavLink, we...

Proposed implementation: https://codesandbox.io/s/wkvno5v9m5

Proposed library for peer applications to use for compatibility with React Router NavLink: https://github.com/penx/as-nav-link

This is in place but needs to be done where we're currently using asAnchor

asAnchor was removed in #814

Reopening to review navlink with respect to https://github.com/remix-run/react-router/issues/6390#issuecomment-912911908

Deploy preview for *govuk-react* processing. Building with commit 88946aa2abd6857dff958fce743e45b35531736f https://app.netlify.com/sites/govuk-react/deploys/5e847ff30277910006cb2850

@mantcz we need someone to review what @dsm23 has done. I'm not personally using govuk-react myself but am maintaining it where I can. Unfortunately this PR is quite extensive so...

@harrynorthover @samuelmaker perhaps this is something you could look at?