Tracking issue: Staking/Distribution QA and testing

[erwanor]

Staking/Distribution QA and testing

Main tracking issue: #3452

In the course of building the staking and distribution components, we frequently uncovered/created bugs in the implementation, either in the form of straight up dysfunctions (e.g. missing state transitions) or in harder to detect invariant violations (e.g. reward overspending).

In both cases, these mistakes could have been caught by leveraging our App test harness.

This issue is a first pass at inventorizing bugs that have occured in the process of [re]developing these components. For now, its purpose is to serve as a basis to guide future assurance work. Later, it will serve as a regular tracking issue that describes roadmap and completion of a project.

Historical bug inventory:

Validator state-machine

• https://github.com/penumbra-zone/penumbra/pull/3770
• https://github.com/penumbra-zone/penumbra/pull/3761

Staking end-epoch handling

• https://github.com/penumbra-zone/penumbra/issues/3814

Rate calculations

• https://github.com/penumbra-zone/penumbra/issues/3802
• https://github.com/penumbra-zone/penumbra/pull/3803

Stake bonding mechanisms

• https://github.com/penumbra-zone/penumbra/pull/3803
• https://github.com/penumbra-zone/penumbra/issues/3738

Validation

• https://github.com/penumbra-zone/penumbra/pull/3820
• https://github.com/penumbra-zone/penumbra/pull/3831
• https://github.com/penumbra-zone/penumbra/pull/3768
• https://github.com/penumbra-zone/penumbra/issues/3858