penumbra icon indicating copy to clipboard operation
penumbra copied to clipboard

app: 🎋 missing `Sct` component hooks

Open cratelyn opened this issue 1 year ago • 5 comments

while reading through the App implementation, i noticed that the Sct component only ever has its init_chain and begin_block hooks called.

this isn't currently a bug, since its end_block and end_epoch hooks are no-ops, but could become one in the future if more logic was introduced to those trait methods.

this is an easy fix, but i'm filing this separately as an issue for reference in a tracking issue elsewhere.

cratelyn avatar Feb 05 '24 16:02 cratelyn

Related to #3712

erwanor avatar Feb 05 '24 16:02 erwanor

@erwanor just to confirm, #3712 won't entail breaking changes to cnidarium::Component, is that right?

cratelyn avatar Feb 05 '24 16:02 cratelyn

That's right, that other ticket is about simplifying app-level handling of end-block/end-epoch. It doesn't require any change to the Component trait.

erwanor avatar Feb 05 '24 16:02 erwanor

That's right, that other ticket is about simplifying app-level handling of end-block/end-epoch. It doesn't require any change to the Component trait.

got it. thank you!

cratelyn avatar Feb 05 '24 16:02 cratelyn

removed my assignment from this issue, to focus on tasks in sprint 0.

cratelyn avatar Feb 20 '24 13:02 cratelyn