penumbra
penumbra copied to clipboard
app: 🎋 missing `Sct` component hooks
while reading through the App
implementation, i noticed that the Sct
component only ever has its init_chain
and begin_block
hooks called.
this isn't currently a bug, since its end_block
and end_epoch
hooks are no-ops, but could become one in the future if more logic was introduced to those trait methods.
this is an easy fix, but i'm filing this separately as an issue for reference in a tracking issue elsewhere.
Related to #3712
@erwanor just to confirm, #3712 won't entail breaking changes to cnidarium::Component
, is that right?
That's right, that other ticket is about simplifying app-level handling of end-block/end-epoch. It doesn't require any change to the Component
trait.
That's right, that other ticket is about simplifying app-level handling of end-block/end-epoch. It doesn't require any change to the
Component
trait.
got it. thank you!
removed my assignment from this issue, to focus on tasks in sprint 0.