penumbra icon indicating copy to clipboard operation
penumbra copied to clipboard

Published 20 hours ago • verified publisher icon penumbra-zone

feat: support display seed phrase discreetly

Open Halimao opened this issue 1 year ago • 4 comments

Running pcli init soft-kms generate will print a seed phrase in the terminal, this is dangerous.

This pr added a new option --display-discreetly to support displaying seed phrases discreetly on an alternate screen.

image

image

Halimao avatar Dec 09 '23 07:12 Halimao

@erwanor @hdevalence GM sir, could you please help me to review this pr😀

Halimao avatar Dec 12 '23 13:12 Halimao

@erwanor Hi sir, could you please help me to review this pr😀

Halimao avatar Jan 08 '24 08:01 Halimao

Hey @Halimao, sorry this took so long but I am going to review this in the next couple days, possibly amending the branch before merging this in. Thanks for taking a stab at this!

erwanor avatar Jan 16 '24 18:01 erwanor

Hey @Halimao, sorry this took so long but I am going to review this in the next couple days, possibly amending the branch before merging this in. Thanks for taking a stab at this!

Hi sir, could u please help me review this PR then?

Halimao avatar Mar 03 '24 05:03 Halimao

Thanks for your patience with this, I didn't want this to sit any longer so I workshopped the PR myself to expedite it, making the alt screen the default option so that it doesn't show in buffered backscrolls. Let's merge this!!

erwanor avatar Jun 10 '24 13:06 erwanor