penumbra icon indicating copy to clipboard operation
penumbra copied to clipboard

refactor(transaction): Implement canonical ordering in `TransactionPlan`

Open TalDerei opened this issue 2 years ago • 6 comments

References #3435

TalDerei avatar Dec 04 '23 20:12 TalDerei

We should also have tie breaking based on the effect hash, rather than just using whatever order between actions that happens to exist (or perhaps something more intricate). Because of this, it might be a good idea to instead shift the approach of this PR to adding an Eq and Ord instance to Action based on this philosophy.

cronokirby avatar Dec 04 '23 20:12 cronokirby

Let's pause work on this until having a better spec of what should be done, it's relatively less important than other changes we should be focusing on right now (getting new builder code integrated into web extension, making breaking changes before next testnet release).

hdevalence avatar Dec 04 '23 20:12 hdevalence

This PR is blocked and will remain as a draft until after the next release.

TalDerei avatar Dec 04 '23 20:12 TalDerei

We are not planning to merge this for Testnet 64, so we'll return to it next week.

conorsch avatar Dec 07 '23 18:12 conorsch

Is this something we want done for the next testnet release? otherwise it can remain in the backlog

TalDerei avatar Mar 03 '24 19:03 TalDerei

Let's keep it in the backlog for now

hdevalence avatar Mar 03 '24 19:03 hdevalence

reopened since #3435 was tagged as V1

TalDerei avatar Mar 22 '24 21:03 TalDerei

blocked until https://github.com/penumbra-zone/penumbra/issues/4081

TalDerei avatar Apr 14 '24 14:04 TalDerei

unblocked by https://github.com/penumbra-zone/penumbra/pull/4312

TalDerei avatar May 03 '24 20:05 TalDerei