testpress icon indicating copy to clipboard operation
testpress copied to clipboard

Add a UI for grunt patch

Open pento opened this issue 7 years ago • 2 comments

Fixes #30.

Testing

Applying Patches From the Browser

  • Install a userscript browser extension. Tampermonkey works everywhere.
  • Visit http://localhost:21853/testpress.user.js
  • Open a ticket on core.trac.wordpress.org.
  • Click the "Open" button next to a patch attachment.

Applying Patches From TestPress

  • Open the Patch UI in TestPress.
  • Paste a link to a patch, and apply it.

Uploading Patches

  • In your WordPress package.json, change the grunt-patch-wordpress version to WordPress/grunt-patch-wordpress, so you get the unreleased changes.
  • Open the Patch UI in TestPress.
  • Enter a ticket number, along with your WordPress.org credentials, and click Upload.

pento avatar Oct 02 '18 21:10 pento

Here a couple of supremely rough screenshots, showing the button that the userscript adds to Trac attachments, as well as the patch screen within TestPress.

Clicking the "Open" button will cause that patch to be applied to your WordPress install, same as running grunt patch would do.

Screenshot of the Open button being added to the trac attachment. Screenshot of the patch screen.

pento avatar Mar 16 '19 08:03 pento

TODO

Uploading UI:

  • The patch upload form needs to be aligned properly.
  • Provide some sort of visual status of whether the patch upload has finished or not.
  • Provide a link to the ticket once the patch is uploaded, as uploading a patch is usually followed by a comment talking about the patch.

General UI:

  • Provide install instructions for the userscript.

Userscript:

  • The "Open" button is pretty ugly. We could make this look nicer.
  • Add the button to attachment links in comments, too.
  • Detect if TestPress is running.
  • Provide feedback of whether the patch has applied or not.

pento avatar Mar 26 '19 04:03 pento