pentaho-kettle icon indicating copy to clipboard operation
pentaho-kettle copied to clipboard

Fixed Main sample which would not compile

Open rajrao opened this issue 2 years ago • 8 comments

The code would through an error of: Line 105, Column 14: Expression "r" is not an rvalue. Fixed and tested as working

rajrao avatar Apr 27 '22 18:04 rajrao

:white_check_mark: Build finished in 17m 42s

Build command:

mvn clean verify -B -e -Daudit -amd -pl ui

:exclamation: No tests found!

:information_source: This is an automatic message

buildguy avatar Apr 28 '22 01:04 buildguy

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rajrao Is there a BACKLOG or PDI case associated with this change?

ddiroma avatar Apr 29 '22 14:04 ddiroma

Hi Dean, I dont think so. I found this issue while I was working with Spoon. Let me know if I should create an issue and associate it with it.

rajrao avatar Apr 29 '22 14:04 rajrao

Sure, there are many small issues that you will come across in Spoon, but any code change will require an appropriate bug/story that will require QA testing. Please log a bug with more context (PDI version, repro steps, testing requirements, etc.). Feel free to assign it to your team and inform your PO and ScrumMaster. Thanks.

ddiroma avatar Apr 29 '22 14:04 ddiroma

Please see: https://jira.pentaho.com/browse/PDI-19509. Also, regarding: "Feel free to assign it to your team and inform your PO and ScrumMaster", I dont work on a Pentaho team. Submitted this patch as a user of Spoon

rajrao avatar Apr 29 '22 17:04 rajrao

:x: Build failed in 2h 26m 52s

Build command:

mvn clean verify -B -e -Daudit -amd -pl ui

:exclamation: No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

:information_source: This is an automatic message

buildguy avatar Jan 27 '23 22:01 buildguy

:x: Build failed in 2m 10s

Build command:

mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox

:exclamation: No tests found!

:information_source: This is an automatic message

buildguy avatar Mar 04 '24 10:03 buildguy