pentaho-kettle icon indicating copy to clipboard operation
pentaho-kettle copied to clipboard

Do not printStackTrace() when RunThread error

Open moonfruit opened this issue 3 years ago • 6 comments

Codes below should not call t.printStackTrace() to print stack to stderr, it should rely on log.logError() do the work.

https://github.com/pentaho/pentaho-kettle/blob/5bbca055f14dd7358619e27674256f7572e8338b/engine/src/main/java/org/pentaho/di/trans/step/RunThread.java#L75-L78

moonfruit avatar Jul 02 '21 06:07 moonfruit

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

:white_check_mark: Build finished in 31m 49s

Build command:

mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!

Tests run: 3935, Failures: 0, Skipped: 7    Test Results


:information_source: This is an automatic message

buildguy avatar Jul 02 '21 07:07 buildguy

@ricksjames @pminutillo Is there any problem with this?

moonfruit avatar Jul 30 '21 05:07 moonfruit

:x: Build failed in 3h 26m 20s

Build command:

mvn clean verify -B -e -Daudit -amd -pl engine

:exclamation: No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

:information_source: This is an automatic message

buildguy avatar Jan 18 '22 21:01 buildguy

:x: Build failed in 2h 30m 3s

Build command:

mvn clean verify -B -e -Daudit -amd -pl engine

:exclamation: No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

:information_source: This is an automatic message

buildguy avatar Jan 27 '23 22:01 buildguy

:x: Build failed in 2m 45s

Build command:

mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox

:exclamation: No tests found!

:information_source: This is an automatic message

buildguy avatar Mar 04 '24 10:03 buildguy