MariaDB dialect detection

[petrprochy]

Improved detection of MariaDB database and fixed behaviour of method allowFromQueue().

Link to JIRA: https://jira.pentaho.com/browse/MONDRIAN-2650

[wingman-pentaho]

Hello, This is an automated comment from our build system. Since this pull request originated from a user not in the Pentaho organization, we will not proceed with automatic validation of the pull request. However, rest assured that it will be reviewed manually as soon as we get the chance. Thanks for your contribution!

[wingman-pentaho]

Build Completed

:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'pom.xml' -pl 'mondrian' -P '!assemblies' -DrunITs=true -Dsurefire.runOrder=alphabetical -Dfailsafe.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'mondrian' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  mondrian/src/it/java/mondrian/spi/impl/MariaDBDialectTest.java
  mondrian/src/main/java/mondrian/spi/impl/JdbcDialectImpl.java
  mondrian/src/main/java/mondrian/spi/impl/MariaDBDialect.java

Integration Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)

mondrian.olap.Util.Flat3List

• Branch Change: -2.7% :small_red_triangle_down:
• Complexity Change: -3.2% :small_red_triangle_down:

mondrian.rolap.agg.SegmentCacheManager.AbortException

• Complexity Change: -100% :small_red_triangle_down:
• Instruction Change: -100% :small_red_triangle_down:
• Line Change: -100% :small_red_triangle_down:
• Method Change: -100% :small_red_triangle_down:

mondrian.rolap.agg.SegmentCacheManager.Actor

• Branch Change: -25% :small_red_triangle_down:
• Complexity Change: -12.5% :small_red_triangle_down:
• Instruction Change: -8.6% :small_red_triangle_down:
• Line Change: -8.8% :small_red_triangle_down:

mondrian.rolap.agg.SegmentLoader

• Branch Change: -1.5% :small_red_triangle_down:
• Complexity Change: -2.4% :small_red_triangle_down:
• Instruction Change: -0.7% :small_red_triangle_down:
• Line Change: -0.8% :small_red_triangle_down:

mondrian.rolap.agg.SegmentLoader.2.new SegmentCacheManager.Command() {...}

• Branch Change: -33.3% :small_red_triangle_down:
• Complexity Change: -33.3% :small_red_triangle_down:
• Instruction Change: -6.8% :small_red_triangle_down:
• Line Change: -6.7% :small_red_triangle_down:

mondrian.rolap.cache.SegmentCacheIndexImpl

• Branch Change: -1.4% :small_red_triangle_down:
• Complexity Change: -2.2% :small_red_triangle_down:
• Instruction Change: -1.2% :small_red_triangle_down:
• Line Change: -1.5% :small_red_triangle_down:

mondrian.rolap.FastBatchingCellReader

• Branch Change: -1.9% :small_red_triangle_down:
• Complexity Change: -3.1% :small_red_triangle_down:
• Instruction Change: -0.4% :small_red_triangle_down:
• Line Change: -1.1% :small_red_triangle_down:

mondrian.server.MonitorImpl.Handler

• Branch Change: -2.2% :small_red_triangle_down:
• Complexity Change: -1.8% :small_red_triangle_down:
• Instruction Change: -0.5% :small_red_triangle_down:
• Line Change: -0.5% :small_red_triangle_down:

mondrian.spi.impl.JdbcDialectImpl

• Complexity Change: -0.3% :small_red_triangle_down:

mondrian.spi.impl.MariaDBDialect

• Complexity Change: -5% :small_red_triangle_down:
• Instruction Change: -2.6% :small_red_triangle_down:
• Line Change: -1.8% :small_red_triangle_down:
• Method Change: -8.3% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Couldn't find acceptable copyright on mondrian/src/it/java/mondrian/spi/impl/MariaDBDialectTest.java

:heavy_exclamation_mark: Couldn't find acceptable license on mondrian/src/it/java/mondrian/spi/impl/MariaDBDialectTest.java

:heavy_exclamation_mark: Copyright year is not the current year on mondrian/src/main/java/mondrian/spi/impl/MariaDBDialect.java. Found 2017. Was expecting 2018

[lucboudreau]

This is a good start, but the PR is incomplete. We will have to add some missing parts when we get to integrating it. HV folks: See the Jira comments for details.

[petrprochy]

Thanks for your reply Luc, I committed changes which failed build. Please, could you review changes?

Thanks and Marry Christmas :-)

[buildguy]

:gear: Build finished in 3m 55s with command:

mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -P !assemblies -pl mondrian

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:gear: Build finished in 4m 37s with command:

mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -P !assemblies -pl mondrian

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:gear: Build finished in 4m 22s with command:

mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -P !assemblies -pl mondrian

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:gear: Build finished in 4m 10s with command:

mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -pl mondrian

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:gear: Build finished in 4m 3s with command:

mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -pl mondrian

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:gear: Build finished in 4m 6s with command:

mvn clean verify -B -e -Daether.connector.resumeDownloads=false -amd \
-Daudit -pl mondrian

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 4m 39s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 4m 38s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 4m 5s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 4m 3s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 4m 9s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 5m 7s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 12m 39s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 7m 54s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 4m 43s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 4m 25s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 4m 37s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 14m 9s

Build command:

mvn clean verify -B -e -Daudit -amd -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[buildguy]

:white_check_mark: Build finished in 8m 52s

Build command:

mvn clean verify -B -e -Daudit -amd -DrunITs -pl mondrian

---

:exclamation: No tests found!

:information_source: This is an automatic message

[hitachivantarasonarqube[bot]]

SonarQube Quality Gate:

Maintainability Rating on New Code (is worse than A)
3 New Code Smells (is greater than 0)

See analysis details on SonarQube

[buildguy]

:x: Build failed in 3h 5m 58s

Build command:

mvn clean verify -B -e -Daudit -amd -DrunITs

---

:exclamation: No tests found!

Errors:

Filtered log (click to expand)

Error fetching remote repo 'origin'

:information_source: This is an automatic message

[buildguy]

:x: Build failed in 1h 45m 44s

Build command:

mvn clean verify -B -e -Daudit -amd -DrunITs -pl mondrian

---

:exclamation: No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

:information_source: This is an automatic message