data-access icon indicating copy to clipboard operation
data-access copied to clipboard

Published 20 hours ago • verified publisher icon pentaho

[TEST] Added unit tests for MetadataServiceUtil and MetadataService …

Open rcanuto opened this issue 8 years ago • 10 comments

…classes

rcanuto avatar Nov 02 '16 10:11 rcanuto

Build Completed

:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

ant -Dtestreports.dir=bin/reports/unit-test -f build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f build.xml jacoco-integration checkstyle

Cleanup Commands

rm -r ~/.ivy2/local || echo no publish local to remove

Changed files

  src/org/pentaho/platform/dataaccess/metadata/service/MetadataServiceUtil.java
  test-src/org/pentaho/platform/dataaccess/metadata/service/MetadataServiceTest.java
  test-src/org/pentaho/platform/dataaccess/metadata/service/MetadataServiceUtilTest.java

Still Broken Tests:

org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testDSW_ACL:

:red_circle: junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: expected:<404> but was:<409>
    at org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testDSW_ACL(DataSourcePublishIT.java:572)
    at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
    at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
    at org.springframework.test.context.junit4.statements.SpringRep
org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testMetadata_ACL:

:red_circle: junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: expected:<404> but was:<409>
    at org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testMetadata_ACL(DataSourcePublishIT.java:445)
    at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
    at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
    at org.springframework.test.context.junit4.statements.Spri
org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testPublishDSW:

:red_circle: com.sun.jersey.api.client.ClientHandlerException

com.sun.jersey.api.client.ClientHandlerException: A message body reader for Java class org.pentaho.platform.repository2.unified.webservices.RepositoryFileAclDto, and Java type class org.pentaho.platform.repository2.unified.webservices.RepositoryFileAclDto, and MIME media type text/plain; charset=iso-8859-1 was not found
    at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:630)
    at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:586)
    at org.pentaho.pl
org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testPublishMetadata:

:red_circle: com.sun.jersey.api.client.ClientHandlerException

com.sun.jersey.api.client.ClientHandlerException: A message body reader for Java class org.pentaho.platform.repository2.unified.webservices.RepositoryFileAclDto, and Java type class org.pentaho.platform.repository2.unified.webservices.RepositoryFileAclDto, and MIME media type text/plain; charset=iso-8859-1 was not found
    at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:630)
    at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:586)
    at org.pentaho.pl

Unit test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

org.pentaho.platform.dataaccess.metadata.model.impl.Column
  • Complexity Change: + 61.90%
  • Instruction Change: + 64.29%
  • Line Change: + 75.00%
  • Method Change: + 61.90%
org.pentaho.platform.dataaccess.metadata.model.impl.Condition
  • Complexity Change: + 4.35%
  • Instruction Change: + 5.58%
  • Line Change: + 10.53%
  • Method Change: + 7.14%
org.pentaho.platform.dataaccess.metadata.model.impl.Order
  • Complexity Change: + 71.43%
  • Instruction Change: + 70.83%
  • Line Change: + 70.00%
  • Method Change: + 71.43%
org.pentaho.platform.dataaccess.metadata.model.impl.Parameter
  • Branch Change: + 50.00%
  • Complexity Change: + 41.67%
  • Instruction Change: + 45.45%
  • Line Change: + 47.37%
  • Method Change: + 45.45%
org.pentaho.platform.dataaccess.metadata.model.impl.Query
  • Complexity Change: + 76.47%
  • Instruction Change: + 80.00%
  • Line Change: + 76.67%
  • Method Change: + 76.47%
org.pentaho.platform.dataaccess.metadata.service.MetadataService
  • Complexity Change: + 2.50%
  • Instruction Change: + 4.76%
  • Line Change: + 4.65%
  • Method Change: + 4.55%
org.pentaho.platform.dataaccess.metadata.service.MetadataServiceUtil
  • Branch Change: + 30.88%
  • Complexity Change: + 25.00%
  • Instruction Change: + 25.63%
  • Line Change: + 31.01%
  • Method Change: + 21.43%

wingman-pentaho avatar Nov 02 '16 11:11 wingman-pentaho

:x: Build failed in 12s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

Pull request 800 : Not mergeable at 70bb8cdba1176aafc993ba493de2ddf4dde7ee05+c53d011f5e92e42fe265de9067c23cb9ff271bca (NOT_MERGEABLE)

:information_source: This is an automatic message

buildguy avatar Nov 06 '19 13:11 buildguy

:x: Build failed in 10s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

/build/wingman/workspace/maintenance/wingman/builds/pentaho.data-access.PR-800/pom.xml does not exist.

:information_source: This is an automatic message

buildguy avatar Jan 04 '20 17:01 buildguy

:x: Build failed in 10s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

/build/wingman/workspace/maintenance/wingman/builds/pentaho.data-access.PR-800/pom.xml does not exist.

:information_source: This is an automatic message

buildguy avatar Jan 08 '20 21:01 buildguy

:x: Build failed in 10s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

/build/wingman/workspace/maintenance/wingman/builds/pentaho.data-access.PR-800/pom.xml does not exist.

:information_source: This is an automatic message

buildguy avatar Jan 17 '20 05:01 buildguy

:x: Build failed in 11s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

Pull request 800 : Not mergeable at 70bb8cdba1176aafc993ba493de2ddf4dde7ee05+c53d011f5e92e42fe265de9067c23cb9ff271bca (NOT_MERGEABLE)

:information_source: This is an automatic message

buildguy avatar Jan 23 '20 17:01 buildguy

:x: Build failed in 15s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

/build/wingman/workspace/maintenance/wingman/builds/pentaho.data-access.PR-800/pom.xml does not exist.

:information_source: This is an automatic message

buildguy avatar Feb 04 '20 17:02 buildguy

:x: Build failed in 1m 24s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

/build/wingman/workspace/maintenance/wingman/builds/pentaho.data-access.PR-800/pom.xml does not exist.

:information_source: This is an automatic message

buildguy avatar Mar 31 '20 12:03 buildguy

:x: Build failed in 3h 57s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

/build/wingman/workspace/maintenance/wingman/builds/pentaho.data-access.PR-800/pom.xml does not exist.

:information_source: This is an automatic message

buildguy avatar Jan 19 '22 00:01 buildguy

:x: Build failed in 30m 20s

Build command:

mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!

Errors:

Filtered log (click to expand) 

/build/wingman/workspace/maintenance/wingman/builds/pentaho.data-access.PR-800/pom.xml does not exist.

:information_source: This is an automatic message

buildguy avatar Jan 27 '23 18:01 buildguy