Update library-file update individual overriden properties

[Malte-Neu]

Steps To Reproduce

I have not been able to repro the problem from the beginning, but I have a file with which it occurs reproducibly.

• Import the bug.penpot file: Bug.penpot.zip
• Open "Wireframe Instance" and check under Assets->Libraries that there is no update.
• Open "Wireframe Template" and change the position of the first artboard. Save and close the document.
• Open "Wireframe Instance" again and the information about the update appears in the library. It should look like this:
• Click on Update the library --> oops and you see this:

Component values have been overwritten and all the work from before is gone. And this although nothing was changed at the components, only at another place a text position was changed.

Expected behavior

Nothing has changed, because no component values have been changed. Even if the components would have changed, all individually overwritten parameters should remain the same.

Actual behavior

You should be able to see from the images what has happened.

Screenshots or video

No response

Desktop (please complete the following information)

Firefox 108.0.1

Smartphone (please complete the following information)

No response

Environment (please complete the following information)

Hosted Version https://design.penpot.app

Frontend Stack Trace

No response

Backend Stack Trace

No response

Additional context

No response

[EvaMarco]

Hello @Malte-Neu I tried to reproduce your problem: Follow my steps and tell me if you did something different.

1. I had a library file with a component. This component is a rectangle with a text.

2. I import this library file into other and create 3 new elements with that component

3. I change the text of two of them and the color of one just to check

4. I went back to the library file and modified the main component

5. Then I updated my file with the library changes

The color and texts changes remain, so I think this is ok.

But please tell me. Have your components nested components? Are your steps very different from mine?

[Malte-Neu]

@EvaMarco it's not that simple. Like you, I have also tried it in a completely new project. Unfortunately, I did not succeed in finding a reproducible way. It has occurred, if I have changed even more like sizes and the whole several times. I also used color templates.

Please try it with my attached file. With it I could reproduce the error as I wrote it down.

[EvaMarco]

Hello @Malte-Neu: I've tried the same with your file.

1. Added some standar labels

2. I went to library page and modify that label with background color and text

3. Come back to the file and and update label Before updating

After updating

As you can see I can not reproduce it eather, but we are going to check it more in deep.

[Malte-Neu]

Look at the other values. The ±23.00 became 123.00 again from the library. And the width properties were also changed. There the properties were overwritten although they should not have been changed at all. In my case, I did not even edit a used component, I just moved an independent text field.

[EvaMarco]

ohh what¡¡ you are right, I was only looking to the labels... my bad. We are going to check it in deep. I will maintain you informed.

Thanks for your patience

[hirunatan]

Sorry, this is a bug affecting component sync of text layers inside components.

I have isolated it (at https://tree.taiga.io/project/penpot/issue/4646) and it's already fixed. This will work well in the next Penpot release.

Until then, you can avoid text layers to be reset by changing anything of their size or position (e.g. changing the text size to "auto width" or moving them a bit and then moving them again to the initial position). The bug was related to the "modified" detection. If you do so, they will be correctly marked as modified and will not be overwritten with the library update.

(BTW: sorry the update library popup currently appears for any change of the library, even moving around an unrelated board; we have in the roadmap to detect what have changed and to show the popup only if there are relevant changes).

[Malte-Neu]

I'm glad to read that the bug was fixed quickly, I am looking forward to the new version. Is it possible to estimate when the deployment to penpot.app will happen?

[EvaMarco]

We are planing a release for the end of this month, but I'm not sure if It will be fixed sooner. Edit -> It's posible that this bug will be fixed by monday. :)

[hirunatan]

Yes, we have planned a hotfix update on monday, and this bug will be included.

[myfunnyandy]

Closing as this one is solved