penn-mobile-android icon indicating copy to clipboard operation
penn-mobile-android copied to clipboard

Difficult to trigger "add to contacts" swipe in directory (tab swipe + favorites swipe conflict)

Open adelq opened this issue 8 years ago • 6 comments

adelq avatar Oct 19 '16 19:10 adelq

We can figure something out for next year. This year's NSO was to get things done asap. Also registrar also has that.

jasontsh avatar Oct 30 '16 01:10 jasontsh

How do you want to do this for registrar?

jasontsh avatar Nov 19 '16 20:11 jasontsh

What do you mean? This bug is for directory

adelq avatar Nov 19 '16 21:11 adelq

Well regardless, do you think it's better to not hide the button underneath? or what do you think should we do it. The design is such that if you really select a tile swiping left you'll get to the hidden button.

jasontsh avatar Dec 02 '16 22:12 jasontsh

The point is that if you swipe left, you will swipe into favorites, not to uncover the hidden button, so it's nearly impossible to actually access. It did not used to have tabs, so swiping worked fine.

adelq avatar Dec 02 '16 22:12 adelq

@tifchang thinks that it's a good feature for the hidden drawer, but we can make it more obvious: https://github.com/daimajia/AndroidSwipeLayout/blob/master/library/src/main/java/com/daimajia/swipe/SwipeLayout.java We can make the first tile to open and close (like 1366) with runOnUIThread. @andrewsi10 will work on this later.

jasontsh avatar Dec 03 '16 17:12 jasontsh