penn-clubs icon indicating copy to clipboard operation
penn-clubs copied to clipboard

Add route for admins to issue tickets to users

Open aviupadhyayula opened this issue 10 months ago • 1 comments

aviupadhyayula avatar Apr 23 '24 03:04 aviupadhyayula

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.92%. Comparing base (fb4e4cf) to head (3169001). Report is 1 commits behind head on ticketing.

:exclamation: Current head 3169001 differs from pull request most recent head f5bb394. Consider uploading reports for the commit f5bb394 to get more accurate results

Files Patch % Lines
backend/clubs/views.py 94.73% 2 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##           ticketing     #679      +/-   ##
=============================================
+ Coverage      70.78%   70.92%   +0.13%     
=============================================
  Files             31       31              
  Lines           6744     6782      +38     
=============================================
+ Hits            4774     4810      +36     
- Misses          1970     1972       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 23 '24 05:04 codecov[bot]

This route bypasses event.ticket_drop_time, so tickets that aren't publicly available yet (i.e. through event/tickets) can still be issued. I think this fits the spirit of why we added the drop time.

Let me know what you guys think.

aviupadhyayula avatar Apr 23 '24 20:04 aviupadhyayula

Permissions (and a test validating this) are the most important thing about this PR

Merging this in so that frontend dev isn't blocked, but main points should be addressed.

aviupadhyayula avatar Apr 25 '24 03:04 aviupadhyayula