penn-clubs icon indicating copy to clipboard operation
penn-clubs copied to clipboard

Add field to profile for user to specify type

Open ezwang opened this issue 3 years ago • 3 comments

The user can specify either undergraduate, graduate, or staff member. Doesn't do much currently, but can be useful for later features if we want to provide relevant members with information tailored to their needs.

Will be good to collect this information early in case we need it later on. There is a detection method, but it is inaccurate and unreliable.

image

@ArmaanT Not sure how this might interfere with centralized user account information on Platform, so tagging you.

ezwang avatar Mar 14 '21 15:03 ezwang

LGTM!

cphalen avatar Mar 14 '21 15:03 cphalen

We have a degree type on our Major model (link) which can differentiate between undergrad and grad. The user should already be in a group called platform_staff if they're a staff memeber

ArmaanT avatar Mar 14 '21 15:03 ArmaanT

Codecov Report

Merging #421 (b20d4ff) into master (a9c96a8) will decrease coverage by 0.05%. The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
- Coverage   74.38%   74.33%   -0.06%     
==========================================
  Files          30       30              
  Lines        5201     5217      +16     
==========================================
+ Hits         3869     3878       +9     
- Misses       1332     1339       +7     
Flag Coverage Δ
backend 74.33% <56.25%> (-0.06%) :arrow_down:
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/clubs/models.py 89.37% <53.33%> (-0.83%) :arrow_down:
backend/clubs/serializers.py 78.13% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9c96a8...b20d4ff. Read the comment docs.

codecov[bot] avatar Apr 11 '21 17:04 codecov[bot]