office-hours-queue icon indicating copy to clipboard operation
office-hours-queue copied to clipboard

Migrated linter fix - (Built on django-migrate and NOT main)

Open benjmnxu opened this issue 10 months ago • 4 comments

Restore backend checks for ohq deployment.

  • Black
  • Flake
  • No Ruff (idk what this is)
  • Backend test cases (which we haven't run in like two years lmao)
  • No Codecoverage. Uses an outdated django.yaml (We need to add codecoverage token into our secrets)

benjmnxu avatar Apr 14 '24 19:04 benjmnxu

Main issue with codecov is just the token I believe. Error message on running codecov:

'Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.'

If the upload token is shared I'll keep looking into it. If it's ohq specific, I'll need to ask Bach or Dan to add it into our secrets

benjmnxu avatar Apr 16 '24 15:04 benjmnxu

Makes sense, lmk if you stumble into anything else

judtinzhang avatar Apr 18 '24 01:04 judtinzhang

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (django-migrate@27f57fc). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             django-migrate     #312   +/-   ##
=================================================
  Coverage                  ?   98.93%           
=================================================
  Files                     ?       25           
  Lines                     ?     1316           
  Branches                  ?        0           
=================================================
  Hits                      ?     1302           
  Misses                    ?       14           
  Partials                  ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 21 '24 18:04 codecov[bot]

Codecov token added. All tests pass.

benjmnxu avatar Apr 21 '24 18:04 benjmnxu