email_changed signal should be sent when changing a primary email using EmailAddress.change

[prakhar1144]

When changing an email using EmailAddress.change() https://github.com/pennersr/django-allauth/blob/c50a30acc0e4553297b0ddb697d55a290ed6d038/allauth/account/models.py#L65

There should be a condition as follows: If the email being changed is a primary email then email_changed signal should be sent. As of now it doesn't happens.

[pennersr]

That change() method is actually dead code and not used by allauth at al. It should be removed altogether.

[arthtyagi]

I think add_email should be used for any use-case stemming from your need to use change method @prakhar1144

[pennersr]

The change() method is no longer present.