logseq-plugin-tabs icon indicating copy to clipboard operation
logseq-plugin-tabs copied to clipboard

unresponsive tabs

Open snowice0 opened this issue 1 year ago • 11 comments

Tabs are currently unresponsive after opening logseq or returning to focus. Turning the plugin on and off from the plugin menu re-enables usability but will be lost again after some time of inactivity

Logseq version: 0.9.9 tabs plugin version: 1.19.1 theme: bonofix windows: 10 number of tabs open: 3 but the experience is the same regardless of number

snowice0 avatar Jun 25 '23 12:06 snowice0

Experiencing the same thing

Logseq 0.9.9 Windows 10 Tabs Plugin 1.19.1 theme: Customized Github theme

~~number of tabs open: more than my horizontal width~~ irrelevant, see below user's comment screen resolution: 1920 x 1080

Reproduction Steps

  • If I open Logseq from scratch, I can click a tab.
  • Following that click, tabs are broken.
    • They don't respond to clicks, they don't respond to mouseover.

Diagnostics

I spent some time trying to come at the problem from whatever angle I could think of. Here are my findings:

  • If you have the dev tools console open, the tab plugin's responsiveness is fine, it doesn't stop working
  • If you have the side bar open wide enough, the tab plugin's responsiveness is fine, it doesn't stop working
  • Close either of the above, and you probably won't have a problem for that session until you resize the window
  • If you resize the window, you're back to square one, tabs become unresponsive
  • Open any kind of sidebar again (dev tools or ordinary) and the tabs immediately work again
  • Wide mode (keyboard t w) appears to have no impact on this.
  • If you move the dev tool sidebar to dock at the bottom of the screen, tabs become unresponsive

isosphere avatar Jun 25 '23 13:06 isosphere

I experience this regardless of the number of tabs open. Right now I have two or three open and there is plenty of horizontal space available

snowice0 avatar Jun 25 '23 13:06 snowice0

Solution / Root Cause

Enabling "Native title bar" in the Logseq settings resolves this issue for me.

Looks like this is a duplicate of #83.

Suggested title for this issue: Unresponsive Tabs with Non-Native Title Bar on Windows

The problems faced by folks in #83 might be the Linux-specific symptoms; I've asked the other users to confirm their platforms.

Here's the logseq PR that merged the integrated title bar feature: https://github.com/logseq/logseq/pull/9442

isosphere avatar Jun 25 '23 14:06 isosphere

Enabling "Native title bar" in the Logseq settings resolves this issue for me.

Looks like this is a duplicate of #83.

Suggested title for this issue: Unresponsive Tabs with Non-Native Title Bar on Windows

The problems faced by folks in #83 might be the Linux-specific symptoms; I've asked the other users to confirm their platforms.

Thanks this solved the issue as well as an unrelated UI issue i had before. But the behaviour was working before the latest logseq version

snowice0 avatar Jun 25 '23 14:06 snowice0

be the Linux-specific symptoms

Windows 11 - same issue

Enabling "Native title bar" in the Logseq settings resolves this issue for me.

confirming, issue gone

yoyurec avatar Sep 20 '23 14:09 yoyurec

I'm experiencing the same issue Logseq version: 0.9.18 
tabs plugin version: 1.19.1
theme: Bonofix, all Awesome Styler themes and default Logseq theme
 MacOs: Ventura 13.5.2
 Happens with any number of tabs

Unfortunately, I don't have the "native titlebar" option on my machine

Screenshot 2023-09-26 at 11 56 35

mjarus008 avatar Sep 26 '23 10:09 mjarus008

Try to fix in this PR #90

xyhp915 avatar Sep 27 '23 08:09 xyhp915

Logseq version: 0.9.18 tabs plugin version: 1.19.2 (new from last post) Theme: Bonofix, all Awesome Styler themes and default Logseq theme
 MacOs: Sonoma 14.0 (new from last post)


@xyhp915 Thank you for taking a look at this so quickly! This works well for me atm:

  • I can click on a tab and it will show the page that I clicked, as expected
  • I drag and drop tabs to rearrange them, as excepted
  • The tab shortcuts still work as usual (pinning is a bit weird, could get Command + P to pin tabs but this might not be a new issue or an issue at all)

I'd like to note a couple of things: It seems that the Tabs plug does not play well with the Awesome UI plugin when the "Move Tabs panel on top?" checkbox is ticked. This is new behaviour I think.

  • Sometimes my navbar would seemingly not be recognised by the system as a navbar (while tabs work perfectly)
    • Double clicking on it does not toggle the min and max window states
    • Dragging on it does not move the window as expected
  • Sometimes the whole top row would be recognised as a navbar (including the tabs)
    • Clicking on a tab does not navigate to that associated page
    • Dragging a tab, drags the whole window
    • When I double click on a tab it toggles the minimised and maximised states
    • Tabs show a default cursor instead of a pointer

https://github.com/pengx17/logseq-plugin-tabs/assets/107445238/2e5379c7-ca5e-4ea5-ae98-39b42f8a85fe

I don't know what triggers the swapping of functionality, sometimes it was a window resize (?), changing themes or changing graphs

I thought I should mention the interesting interplay between these two plugins for that one option but I don't mind keeping that option off. Thanks!

mjarus008 avatar Sep 27 '23 10:09 mjarus008

Logseq version: 0.9.18 tabs plugin version: 1.19.2 (new from last post) Theme: Bonofix, all Awesome Styler themes and default Logseq theme
 MacOs: Ventura 14.0 (new from last post)


@xyhp915 Thank you taking a look this so quickly! This works well for me atm:

  • I can click on a tab and it will show the page that I clicked, as expected
  • I drag and drop tabs to rearrange them, as excepted
  • The tab shortcuts still work as usual (pinning is a bit weird, could get Command + P to pin tabs but this might not be a new issue or an issue at all)

I'd like to note a couple of things: It seems that the Tabs plug does not play well with the Awesome UI plugin when the "Move Tabs panel on top?" checkbox is ticked. This is new behaviour I think.

  • Sometimes my navbar would seemingly not be recognised by the system as a navbar (while tabs work perfectly)

    • Double clicking on it does not toggle the min and max window states
    • Dragging on it does not move the window as expected
  • Sometimes the whole top row would be recognised as a navbar (including the tabs)

    • Clicking on a tab does not navigate to that associated page
    • Dragging a tab, drags the whole window
    • When I double click on a tab it toggles the minimised and maximised states
    • Tabs show a default cursor instead of a pointer

Screen.Recording.2023-09-27.at.12.24.34.mov I don't know what triggers the swapping of functionality, sometimes it was a window resize (?), changing themes or changing graphs

I thought I should mention the interesting interplay between these two plugins for that one option but I don't mind keeping that option off. Thanks!

Hi, @mjarus008 Thanks for your patience! I can reproduce this issue with the Awesome UI plugin. I will try to fix it with a small PR for the Awesome UI plugin asap :)

xyhp915 avatar Sep 27 '23 12:09 xyhp915

will try to fix it with a small PR for the Awesome UI

I think it should work good with new Tabs version... will check

yoyurec avatar Sep 27 '23 12:09 yoyurec

Can still confirm this issue on my end on v. 1.19.1 of this plugin. Tabs are unresponsive/unclickable as described in #90.

It has to do with the z-index of the #logseq-tabs_lsp_main html element.

  • Changing it with a custom.css didn't make a difference, because something was constantly overriding that z-index.
  • Turns out it was a mouse over event, which was being triggered by the plugin's js file.
  • I made an ugly temporary fix on my side by changing excluding the on plugins\logseq-tabs\dist\assets\index.c46f218f.js

image

u-4589 avatar Feb 10 '24 13:02 u-4589