logseq-plugin-tabs icon indicating copy to clipboard operation
logseq-plugin-tabs copied to clipboard

feature request : have a tab for the journal page

Open thiswillbeyourgithub opened this issue 3 years ago • 8 comments

I also think it would be great to have the "all journals" page as a tab. Otherwise I have to open the daily page (and not all days page) as a separate tab but that's a bit cumbersome.

thiswillbeyourgithub avatar Jun 04 '22 16:06 thiswillbeyourgithub

+1 it is quite confusing that the journal does not appear as a tab.

dansseg avatar Jan 04 '23 10:01 dansseg

If I recall correctly, the reason is that the journals page route path could be the root path /, instead of /journals which makes it a special case that has to be handled. I think the fix should be relatively straightforward but I haven't have a time to fix it yet.

pengx17 avatar Jan 05 '23 02:01 pengx17

+100

The most important page for me is my home page (i.e. journals page), so the exclusion of this page makes the ctrl-tab workflow almost useless to me.

nikhilmaddirala avatar Jan 30 '23 19:01 nikhilmaddirala

This was implemented. Please check if it can be closed.

dansseg avatar May 05 '23 20:05 dansseg

Amazing! It's working perfectly for me - thank you so much!

nikhilmaddirala avatar May 05 '23 20:05 nikhilmaddirala

It seems that when I have two tabs open : the first on the left being Journals and the one on the right being a page. If I'm inside the tab on the right and use the shortcut to close it. Expected behavior is that I would be in the Journal tab but instead I'm in an "empty" journals page. Here are pictures to illustrate :

image image

Now just after the shortcut : image

This behavior is not present when I'm in a regular page in the left tab instead of the journals page.

Another interesting thing that might be related is that if I only have 1 tab open which is the journal, I can close it using the shortcut and will end up simply reloading the journals page. Whereas if I'm in another page in only one tab and close it : I end up in the journals page as expected.

edit : in case this gets too complicated, I think a simple hacky workaround that checks if the page is journals and empty when there is a journals page not empty then reload would be fine?

thiswillbeyourgithub avatar Jun 30 '23 14:06 thiswillbeyourgithub

+1 i have a tab named "gj" containing the journals page. I wonder where this naming comes from. Capture

VorsichtGlars avatar Feb 07 '24 09:02 VorsichtGlars