logseq-plugin-tabs
logseq-plugin-tabs copied to clipboard
[Feature Request] Put tabs on top most area, like web browser.
A theme called Solarized-Extended-Theme put the tabs on top most area, just like what web browsers do.
After using it for a couple of days, I find this tweak very useful. Would you consider to make it default behavior? Thanks!
This is an interesting option. I think I can provide an option to make it more like traditional tabs.
FYI
- CSS for moving app down to have space for tabs (just add css flag on plugin init
.is-tabs-loaded
) https://github.com/yoyurec/logseq-solarized-extended-theme/blob/main/src/theme.css#L760-L788 - also you need OS flag from Logseq https://github.com/yoyurec/logseq-solarized-extended-theme/blob/main/src/tabsPlugin.css#L6-L8 + https://github.com/yoyurec/logseq-solarized-extended-theme/blob/main/src/index.ts#L93-L95
- Tabs styling for inspiration - https://github.com/yoyurec/logseq-solarized-extended-theme/blob/main/src/tabsPlugin.css
Main question: how to color tabs? I have just my theme to support, author need to figure out how to support ALL of themes colors. Even simple "unthemed" look need access to Logseq CSS vars inside iframe ((
Main question: how to color tabs? I have just my theme to support, author need to figure out how to support ALL of themes colors. Even simple "unthemed" look need access to Logseq CSS vars inside iframe ((
At least 3-4 main level colors + text color (https://github.com/yoyurec/logseq-solarized-extended-theme/blob/main/src/theme.css#L56-L60) should be "transfered" from app to plugin iframe and reused... but it's also not 100% that theme creators use them...
const appVar1 = getComputedStyle(parent.document.documentElement).getPropertyValue('--ls-primary-background-color');
document.documentElement.style.setProperty('--ls-primary-background-color', appVar1);
oh, looks like color support was added! 🎉 https://github.com/pengx17/logseq-plugin-tabs/releases/tag/v1.15.0
This request is a bit like closed #37. Just a mention, is it possible to custom like #37 - move the tabs to the left side of toolbar? Of course this #41 and #37 both seem good. Plus, so many new customized features appeared recently, like styling tabs color(#13) and hide icon(#35). I think is time to update a part in readme to describe the customizable features, or getting them all in plugin gui settings. What do you say so?
@Gitbreast a PR is welcome :)
@pengx17 I find out @yoyurec doing a great job in self-adjusting Tabs' color and position through the Awesome UI. With you two and your works the UI is almost perfect ;)