logseq-plugin-tabs icon indicating copy to clipboard operation
logseq-plugin-tabs copied to clipboard

fix: close tabs with CTRL+W

Open pengx17 opened this issue 2 years ago • 2 comments

Per discussion in https://github.com/pengx17/logseq-plugin-tabs/commit/24d9445b51d707eea635bb9f3cb3373d5794f850

Because the shortcut registering in Logseq API does not prevent default browser behaviors and the old way of registering shortcuts (in the deleted codes above) is not that reliable, I changed the shortcut to "shift+ctrl+w" shortly after.

I also think the current shortcut (shift+ctrl+w) is not that intuitive. Here are two things I am considering:

contribute upstream Logseq to add an option to prevent from event popping up if it is registered in the meantime, find a solution to always prevent ctrl+w behavior through the plugin ...

pengx17 avatar Apr 18 '22 02:04 pengx17

For macOS, we could manually change the keyboard of Close Window image

usoonees avatar Apr 29 '22 12:04 usoonees

@usoonees yeah, this can be configured in the OS, but I think the fundamental issue is that plugin registered keybindings will still pop up to the outer and triggers some other default behaviors. I guess the solution is still up to the upstream in Logseq core.

pengx17 avatar Apr 29 '22 13:04 pengx17