logseq-plugin-bullet-threading icon indicating copy to clipboard operation
logseq-plugin-bullet-threading copied to clipboard

Please adapt the new theme of logseq.

Open uzvg opened this issue 1 year ago • 1 comments

Focus Line can't align.

Hi, I'm using logseq in archlinux, with official accent color dark theme.

The focus line always can't align, I refreshed, restart the app, none of them works.

This makes perfectionists like me feel a little uncomfortable.

Screenshot from 2023-12-09 00-51-36

uzvg avatar Dec 08 '23 16:12 uzvg

Hey @uzvg, I don't know enough about the new theme (or this plugin!) to submit a fix PR, but for now, I've fixed this by loading the plugin via custom.css, and adding the following fixes:

@import url("https://cdn.jsdelivr.net/gh/pengx17/logseq-dev-theme@master/bullet_threading.css");
/* Bullet threading fixes */
.ls-block[haschild] > div > .block-content-wrapper::before {
  left: -13px;
}
.ls-block .ls-block > div > div.block-control-wrap::before {
  right: 16px;
}
.ls-block > .items-baseline {
  align-items: initial !important;
}

The left,right lines are already in the plugin, so I guess they need an !important now or something? I haven't widely tested the align-items change yet, but it centers the text against the dot point at all times, instead of things jumping around.

Screenshot 2024-02-11 at 1 41 12 am

d3v1an7 avatar Feb 10 '24 14:02 d3v1an7

Hey @uzvg, I don't know enough about the new theme (or this plugin!) to submit a fix PR, but for now, I've fixed this by loading the plugin via custom.css, and adding the following fixes:

@import url("https://cdn.jsdelivr.net/gh/pengx17/logseq-dev-theme@master/bullet_threading.css");
/* Bullet threading fixes */
.ls-block[haschild] > div > .block-content-wrapper::before {
  left: -13px;
}
.ls-block .ls-block > div > div.block-control-wrap::before {
  right: 16px;
}
.ls-block > .items-baseline {
  align-items: initial !important;
}

The left,right lines are already in the plugin, so I guess they need an !important now or something? I haven't widely tested the align-items change yet, but it centers the text against the dot point at all times, instead of things jumping around.

Screenshot 2024-02-11 at 1 41 12 am

thanks, I applied the css fixes directly to the js source and it worked perfectly. I would make a PR, but in fact is your change and I do not want to take ownership of something that is not mine ;)

EDIT: Also, I should add that for me, the bullet threading was working perfectly until last logseq update (in manjaro) last week.

estebanlm avatar May 09 '24 07:05 estebanlm

Last code snippet only fixed desktop, this will also fix mobile:

@import url("https://cdn.jsdelivr.net/gh/pengx17/logseq-dev-theme@main/bullet_threading.css");
/* Bullet threading fixes */
.ls-block[haschild] > div > .block-content-wrapper::before {
  left: -13px;
}
.ls-block .block-children > .ls-block::before {
  left: -11px;
}
.ls-block .ls-block > div > div.block-control-wrap::before {
  left: -11px;
  right: 16px;
}
@media (min-width: 640px) {
  .ls-block .block-children > .ls-block::before {
    left: -1px;
  }
  .ls-block .ls-block > div > div.block-control-wrap::before {
    left: -1px;
  }
}

d3v1an7 avatar Aug 02 '24 03:08 d3v1an7