fumblr icon indicating copy to clipboard operation
fumblr copied to clipboard

Whats wrong with this theme file?

Open millisami opened this issue 14 years ago • 4 comments

The theme I want to customize is the Effector theme.

This is the html theme file: https://gist.github.com/1475351#file_theme.html

And this is the compiled one: https://gist.github.com/1475351#file_compiled_theme.html

Do look at the compiled file, its not being parsed properly.

Other theme files such as demo, 101, ... gets parsed correctly.

Whats wrong with this theme file that Thimblr cannot parse it correctly?

millisami avatar Dec 14 '11 05:12 millisami

While digging into it, I figured out that if the meta has spaces in between, it doesn't get parsed by the thimblr.

e.g.

<meta name="font:Outside Text" content="Helvetica Neue, Arial, sans-serif"/>
<meta name="color:Outside Text" content="#616566"/>
body { font-family:{font:Outside Text}; color:{color:Outside Text};

The rendered html is:

body { font-family:{font:Outside Text}; color:{color:Outside Text};

But when the spaces in between are removed, .e.g <meta name="font:OutsideText" .., it parses for this attribute only.

If this is the case, then I've to remove the spaces from every meta tags.

So I think its a bug inside the Thimblr or am I doing it wrong?

millisami avatar Dec 15 '11 08:12 millisami

Though I've removed every spaces for those meta tags, not all are parsed correctly.

Is the themefile or source of thechangelog.com is released publicly? So that I can look into it.

millisami avatar Dec 19 '11 11:12 millisami

I'm not currently using fumblr for The Changelog, since we're migrating off Tumblr for that site. The parser is simply thimblr under the hood. You might post your question there.

pengwynn avatar Dec 21 '11 03:12 pengwynn

Alright!!

Actually I'd posted at thimblr https://github.com/jphastings/thimblr/issues/7

Didn't hear anything back, so that I posted here.

millisami avatar Dec 21 '11 07:12 millisami