genimage icon indicating copy to clipboard operation
genimage copied to clipboard

image-android-sparse: make the CRC optional

Open bith3ad opened this issue 1 year ago • 1 comments

Recent Android fastboot tools don't support sparse images containing the CRC at the end of the image and instead fail with an coredump. Checking the fastboot code base there are no promising commits that this will change in the near future:

| commit 94d05063ba7d2a2d614733d179c4bce94cead362 | Author: Hridya Valsaraju [email protected] | Date: Tue Oct 2 10:08:38 2018 -0700 | | Remove tests for sparse images with CRC from fuzzy_fastboot | | Sparse images with CRC are currently not supported by the | Android build system. | | Test: ./fuzzy_fastboot --gtest_filter=Conformance.* | Change-Id: I6a73fb0dc5d4c77a3d1a0384c137789eb06fa956

Therefore make the crc optional and turn it of by default to have an better user experience. This is also what img2simg does except for the fact that they don't support adding the crc at all.

bith3ad avatar Feb 26 '24 18:02 bith3ad

The test fails, probably because the CRC is now missing. Can you please enable the CRC for the existing test and create a new one without CRC.

michaelolbrich avatar Feb 27 '24 11:02 michaelolbrich