aiohttp-json-rpc icon indicating copy to clipboard operation
aiohttp-json-rpc copied to clipboard
verified publisher icon pengutronix

Make prepare_request() asynchronous

Open michael-sulyak opened this issue 5 years ago • 5 comments

michael-sulyak avatar May 23 '20 10:05 michael-sulyak

why make asynchronous a function that not have any async thing

andrew-ld avatar May 23 '20 11:05 andrew-ld

Because other developers can write their auth_backend and there may be calls to asynchronous functions.

michael-sulyak avatar May 23 '20 11:05 michael-sulyak

hi @andrew-ld,

looks good to me. could you add your comment on why you want this method to be async to your commit message?

fscherf avatar May 23 '20 14:05 fscherf

@fscherf done

michael-sulyak avatar May 23 '20 14:05 michael-sulyak

@expert-m thx! I will merge your pr in the next release. Currently your patch will break the django login backend which has no tests currently, but is a very critical piece of code for my company.

fscherf avatar May 23 '20 14:05 fscherf