gnome-openweather icon indicating copy to clipboard operation
gnome-openweather copied to clipboard

Changing any setting value causes the weather panel to completely reload

Open ferdnyc opened this issue 9 months ago • 2 comments

Description

I suppose it's debatable whether this is a bug, but it certainly seems like an undesirable inefficiency.

For every value change in the Settings, the weather display in the top bar is completely reloaded. Like, it goes back to "↺ …" for a second or two before restoring the current temp/conditions display.

That includes each. individual. step. that you increment/decrement, say, the First Boot Delay -- a setting that can't possibly have any effect on the currently running weather instance.

(I'm particularly concerned about whether the extension might be re-downloading weather data from the provider, which would be especially bad. But even if it's not, a complete reload of the visual elements just because a setting changed, regardless whether it has any effect on the displayed information, seems like swatting a fly with a sledgehammer.)

System

Fedora 40

Settings

{"app-version":"135","git-version":"135.r0.ge994aeb","gnome-version":"46.1","user-locale":"en","unit":"'fahrenheit'","appid":"<KEY>","actual-city":"0","has-run":"true","days-forecast":"5","delay-ext-init":"5","locs":"[(0, '<NAME>', 0, '<PLACE>')]","expand-forecast":"true","weatherapidotcom-key":"<KEY>","use-system-icons":"true","pressure-unit":"'mmHg'","loc-refresh-interval":"60.0","position-in-panel":"'center'","wind-speed-unit":"'mph'"}

ferdnyc avatar May 14 '24 18:05 ferdnyc