pendulum icon indicating copy to clipboard operation
pendulum copied to clipboard

Add Rust format checker to CI

Open TorstenStueber opened this issue 1 year ago • 5 comments

Currently the formatting of code in PRs is not checked and therefore we have a lot of improperly formatted code on main (e.g., the spacing around the / operator is missing here).

This leads to a situation where some PRs happen to be overly bloated as they happen to correct the formatting of some code files that might not even be related to the PR.

TODO

  • add cargo fmt --check as a step to CI and let the action fail if it exits with non-0
  • apply proper formatting to the complete repository

TorstenStueber avatar May 20 '24 18:05 TorstenStueber

@pendulum-chain/product this is to keep the code base healthy and to make code reviews more straight forward.

TorstenStueber avatar May 20 '24 18:05 TorstenStueber

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t

TorstenStueber avatar May 20 '24 18:05 TorstenStueber

@pendulum-chain/devs should i move this to icebox or good to have?

prayagd avatar Mar 05 '25 06:03 prayagd

I would vote to icebox it for now.

gianfra-t avatar Mar 05 '25 14:03 gianfra-t

Yes, let's icebox it.

ebma avatar Mar 05 '25 15:03 ebma