pendulum icon indicating copy to clipboard operation
pendulum copied to clipboard

Remove the custom migration logic from all runtimes

Open ebma opened this issue 1 year ago • 6 comments

As part of our efforts to upgrade the dependencies to v0.9.42, we added custom migration logic to all runtimes. Now that these changes are rolled out and all the migrations applied, we can remove that extra logic again.

TODO

  • Remove the CustomOnRumtimeUpgrade implementations again
  • Remove the customized dependencies. We had to create forks of some projects in order to be able to modify their migration logic. We can delete those forks again and switch back to the 'official'/upstream dependency versions.

ebma avatar Apr 18 '24 09:04 ebma

@pendulum-chain/product this is more of a chore but nice-to-have and low effort. We can clean up some unnecessary code and repositories with this.

ebma avatar Apr 18 '24 09:04 ebma

Hey team! Please add your planning poker estimate with Zenhub @b-yap @bogdanS98 @ebma @gianfra-t @TorstenStueber

prayagd avatar Apr 25 '24 09:04 prayagd

I think we can reuse this ticket and remove the custom migration logic after the 1.1.0 upgrade is completed. Otherwise we would need to re-add them soon.

gianfra-t avatar Jul 08 '24 13:07 gianfra-t

Right, let's do that. I added the ticket as a blocker to the Zenhub dependencies.

ebma avatar Jul 08 '24 13:07 ebma

@ebma is this possible to be worked on now, or only after the upgrade on Pendulum?

vadaynujra avatar Sep 26 '24 09:09 vadaynujra

@vadaynujra only once we have updated the runtimes we can remove this extra code. We left this ticket also as a reminder to remove the extra logic after the runtime upgrade that bumps to 1.1.0 is enacted on all runtimes.

In any case, this is not blocking anything.

gianfra-t avatar Sep 26 '24 15:09 gianfra-t