pendulum icon indicating copy to clipboard operation
pendulum copied to clipboard
verified publisher icon pendulum-chain

178 add benchmarks for custom pallets per runtime

Open bogdanS98 opened this issue 1 year ago • 4 comments

@pendulum-chain/product: This PR adds changes to the node client code that require a redeployment of the collator nodes to take effect. Please ensure that the collator nodes are redeployed after this PR is merged.

Closes #178.

Note:

  • parachain-staking and issue pallets benchmarks are not yet included in any runtime. The former's benchmarks are failing because of missing conversion of u64 into BlockNumber, the latter's are failing because of InsufficientBalance error. Currently fixing these issues.
  • redeem pallet benchmarks are not yet included in Pendulum runtime. Currently fixing benchmarks failing with ExistentialDeposit error.

bogdanS98 avatar Apr 16 '24 19:04 bogdanS98

Note:

  • parachain-staking and issue pallets benchmarks are not yet included in any runtime.
  • nomination , redeem , replace, vault-registry pallets benchmarks are not yet included in Pendulum runtime.

Should we just add them then or is there a good reason not to?

Please ensure that the collator nodes are redeployed after this PR is merged.

What changes require the redeployment of the collator nodes?

ebma avatar Apr 17 '24 17:04 ebma

Should we just add them then or is there a good reason not to?

Yes, we should add them. They're not added yet because I'm still getting some errors on some benchmarks and I'm trying to fix them. Meanwhile everything that's already added in the PR can be reviewed as it's independent of the missing pallets.

What changes require the redeployment of the collator nodes?

I modified Cargo.toml and chain_spec.rs files from the node directory; updated Spacewalk pallets versions and some minor changes in the genesis configs.

bogdanS98 avatar Apr 18 '24 08:04 bogdanS98

Is this now ready for a re-review or are you still adding more changes to it?

ebma avatar May 03 '24 14:05 ebma

Is this now ready for a re-review or are you still adding more changes to it?

Still adding changes

bogdanS98 avatar May 03 '24 14:05 bogdanS98

@bogdanS98 what's the status with this? Do you need help here?

ebma avatar May 31 '24 09:05 ebma

Any actions for us to take wrt the node upgrades @ebma ?

vadaynujra avatar Jun 04 '24 07:06 vadaynujra

Good question @vadaynujra. @bogdanS98 in the description you mention that the nodes need to be redeployed. Looking at the PR, there are some changes to files in the node folder. However, to me it seems like these changes don't really require a redeployment. Changing the chain spec does not affect the operation of the nodes. What do you think?

ebma avatar Jun 04 '24 07:06 ebma

@ebma Indeed changing the chain spec does not affect the operation of the nodes, I'll update the description 👍🏼

bogdanS98 avatar Jun 04 '24 10:06 bogdanS98