pencil
pencil copied to clipboard
Can't move keyframes on timeline while using move tool
Issue Summary
Moving keyframes on the timeline doesn't work when the move tool is selected. The problem is caused by MoveTool::switchingLayer() which calls deselectAll and therefore every time the function is called (which happens in TinelineCells::mousePressEvent, any keyframes will be deselected before being selected again. The result is that the keyframe looks selected but you can't move it.
The problem stems from #1343 because calling Editor::deselectAll, now also deselects all keyframes on the timeline.
Actual Results
Frames are not being moved
Expected Results
Frames would be moved
Steps to reproduce
- Select the move tool
- Select and drag a keyframe on the timeline.
System Information
Nightly Build Oct 22 2021
commit: 34ea91665bc09e7f116b57abe2208eb40798c3bc date: 2021-10-22_14:41:53
Operating System: macOS 10.15 CPU Architecture: x86_64 Qt Version: 5.15.2
Ah, so I wasn't crazy last time! 😂 Last week there was a moment during my QA testing for the timeline actions PR where I ran into this problem but I thought it was because I had misunderstood the dragging behavior.
I've just tested this again under Windows 10 and I can confirm this is happening as per the reproduction steps. Thank you for reporting! 🙏