Using Bucket tool where no keyframe exists, creates a new keyframe

[davidlamhauge]

Issue Summary

If you use the bucket tool, on a frame with no keyframe, it creates a keyframe itself. That can't be expected behaviour, and I can't recall seeing it or anyone reporting this before.

Video or Image Reference

Steps to reproduce

1. Open Pencil2d, and select a bitmap or vector layer
2. Go to frame 5
3. Select Bucket tool, and maybe a color
4. Fill somewhere inside camera field
5. You'll see that there is a keyframe on frame 5

System Information

• Pencil2D Version: updated master branch

• Operating System: Win10

• RAM Size:

• Graphics Tablet:

[MrStevns]

This is the expected behaviour if the "drawing on an empty frame" is set to create a new keyframe.

It's not a bug.

[MrStevns]

I can see though that it also creates a blank frame if you set it to "keep drawing on the previous key-frame" and undo the fill. That however is a bug.

[davidlamhauge]

Yes, no matter what, it creates a blank keyframe. Personally I don't link it to what happens when you draw on an empty frame. Drawing is one thing and filling is another. For me, it simply makes no sense to try to fill, where there's nothing to fill, so if keyframe doesn't exists, it shouldn't be possible to fill.

[davidlamhauge]

I tried to reproduce the bug you mentioned @MrStevns , but I can't. Can you still reproduce it, or could we close this issue?

[Jose-Moreno]

@MrStevns @davidlamhauge I tried using keep drawing on the previous key-frame and fortunately it does not create a blank frame for me either. I think we can safely close this bug report. It's possible it was fixed with MrStevns timeline actions implementation. However let's wait for Oliver to confirm in order to close this.