localbitcoins icon indicating copy to clipboard operation
localbitcoins copied to clipboard

2.0 branch

Open tennantje opened this issue 8 years ago • 4 comments

Hi,

I'm working on a 2.0 branch for this; my fork is https://github.com/tennantje/localbitcoins which I forked from https://github.com/zachlatta/localbitcoins (who has also made some recent improvements).

Why 2.0? With no updates to the main branch in 2 years, there are a significant amount of gems in the gemspec that are out of date, and clash with modern applications. In particular, Activesupport, for rails apps. I don't want to break backwards compatability for any legacy apps that are currently working with version 1.1 of this gem.

Would you please create a Version 2.0 branch so I can send a pull request? Alternatively, create a new 1.1 branch for the current version, and I can send a pull request against the master?

Regards, Jeremy

tennantje avatar Nov 15 '16 00:11 tennantje

Bump

tennantje avatar Feb 04 '17 01:02 tennantje

Hi @tennantje, thanks for the message. I will talk to John and Will about this!

albiebrown avatar Jun 24 '17 15:06 albiebrown

Hi @tennantje, sorry for the very long delay. I created a 2.0 branch that you can send a pull request to.

pemulis avatar Sep 19 '17 21:09 pemulis

Hi @tennantje, feel free to do a pull request now!

albiebrown avatar Feb 13 '18 01:02 albiebrown