Any plans for supporting 4.1?

[easyaspi314]

A significant number of users (7%) are still on Android 4.1, API 16. Is there any paarticular reason we are only going to 4.2?

We could also probably go down to Gingerbread with NotificationCompat.

I am working on some major improvements currently for my fork, and would like to know.

[pelya]

Yes, there was some API I was using, that was only on Android 4.2. I need to check the code. On Apr 30, 2016 4:54 PM, "easyaspi314 (Devin)" [email protected] wrote:

A significant number of users (7%) are still on Android 4.1, API 16. Is there any paarticular reason we are only going to 4.2?

We could also probably go down to Gingerbread with NotificationCompat.

I am working on some major improvements currently for my fork, and would like to know.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/pelya/screen-dimmer-pixel-filter/issues/7

[easyaspi314]

Found it, thanks.

[easyaspi314]

OK so I think the code is Display.getRealSize();.

I found a solution that may work using reflection on 4.0-4.1 and the current method on 4.2+.

I will test it this evening on an emulator.

[easyaspi314]

I also heard that KitKat blocked overlays on the navbar completely because it could be a DDoS. So that might be why we are getting the weird patterns on some devices. We are trying to squash it.

I will test some stuff.

[easyaspi314]

@pelya can you explain what exactly you are doing here?

        Point displaySize = new Point();
        windowManager.getDefaultDisplay().getRealSize(displaySize);
        Point windowSize = new Point();
        windowManager.getDefaultDisplay().getSize(windowSize);
        displaySize.x += displaySize.x - windowSize.x;
        displaySize.y += displaySize.y - windowSize.y;

[pelya]

That's an attempt to cover system navigation buttons, it works in recent apps list on Nexus 7, but in most cases nav buttons cannot be drawn over. On Apr 30, 2016 8:32 PM, "easyaspi314 (Devin)" [email protected] wrote:

@pelya https://github.com/pelya can you explain what exactlynyou are doing here?

    Point displaySize = new Point();
    windowManager.getDefaultDisplay().getRealSize(displaySize);
    Point windowSize = new Point();
    windowManager.getDefaultDisplay().getSize(windowSize);
    displaySize.x += displaySize.x - windowSize.x;
    displaySize.y += displaySize.y - windowSize.y;

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/pelya/screen-dimmer-pixel-filter/issues/7#issuecomment-215982463

[pelya]

Yes, for KitKat the app shows a dialog to make user allow it 'draw over other apps' permission in the in system settings. On Apr 30, 2016 8:55 PM, "Sergii Pylypenko" [email protected] wrote:

That's an attempt to cover system navigation buttons, it works in recent apps list on Nexus 7, but in most cases nav buttons cannot be drawn over. On Apr 30, 2016 8:32 PM, "easyaspi314 (Devin)" [email protected] wrote:

@pelya https://github.com/pelya can you explain what exactlynyou are doing here?

    Point displaySize = new Point();
    windowManager.getDefaultDisplay().getRealSize(displaySize);
    Point windowSize = new Point();
    windowManager.getDefaultDisplay().getSize(windowSize);
    displaySize.x += displaySize.x - windowSize.x;
    displaySize.y += displaySize.y - windowSize.y;

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/pelya/screen-dimmer-pixel-filter/issues/7#issuecomment-215982463