pytest-poo icon indicating copy to clipboard operation
pytest-poo copied to clipboard

Confusion around markers

Open okken opened this issue 4 years ago • 1 comments

Just curious about the reason for:

  1. Needing to mark tests for this to work
  2. Marking reporting tests with mark regardless of pass/fail status.

I know this was part of a talk or something that I missed.
My assumption about the --poo flag was that it would mark failures with 💩.
It was surprising to me that it was based on the poo marker instead.

I guess it's fine. Just wondering about the reason.

Would you be open to adding a 🙂 or something for passing poo marked tests? Or maybe dropping markers and just 💩-ing all failed tests?

okken avatar Mar 25 '21 17:03 okken

I had a bunch of tests that I was not too proud of (some tests that inherited a huge Unittest base class with huge/inflexible setUp of heavy database objects). I could not get rid of them immediately so I replaced them over time. To give some visual output, I marked the base class with pytestmark=pytest.mark.poo and replace the dots with poos when invoked with --poo. So it was not really a way of showing pass vs fail. I did not put too much thought into this to be honest. 😄

The origin of pytest-poo is from my talk on pytest+django at EuroPython 2013 where I showed this: https://youtu.be/aUf8Fkb7TaY?t=1732. Some people thought it was fun and those 6 lines were then moved into pytest-poo on the train from EuroPython. :)

I still work on that same project every day and fortunately, all those bad tests are now gone and pytest-poo is no longer a dependency I use anymore. 😅

pelme avatar Mar 25 '21 19:03 pelme