TweakScale icon indicating copy to clipboard operation
TweakScale copied to clipboard

investigate interactions with fuelSwitch mods

Open pellinor0 opened this issue 8 years ago • 2 comments

There seem to be problems with several fuel switch mods lately, probably something changed in the base game. MFT applies resource costs twice (even when on its own), interaction with CC (configurable containers) also seems broken.

If FSfuelSwitch is present, I now ignore resource costs when calculating GetModuleCost. It might make sense to also do that for other fuelSwitch modules.

I recently changed to look at prefab-cost and prefab-resources when calculating dryCost (before: part-resources). This fixes things with FSFuelSwitch but might break something else. Overall it seems the more consistent thing to do.

List of fuel switch mods with TweakScale interaction:

  • FSFuelSwitch
  • configurableContainers
  • MFT (/realFuels)
  • B9PartSwitch
  • IFS

pellinor0 avatar Nov 29 '16 18:11 pellinor0

There seem to be issues with RealFuels - TweakScale tells the tank module to rescale, so it modifies the mass, then the Tweakscale module also tries to modify the mass, which can result in negative mass for downscaled tanks. Would it be possible to disable TweakScale setting the mass on any part with a particular module?

https://github.com/NathanKell/ModularFuelSystem/issues/165

Not sure if ModularFuelTanks has the same issue or not.

blowfishpro avatar Jan 04 '17 22:01 blowfishpro

B9PartSwitch was working the last time I checked

blowfishpro avatar Jan 04 '17 22:01 blowfishpro