slugger icon indicating copy to clipboard operation
slugger copied to clipboard

Update junidecoder

Open jcf opened this issue 10 years ago • 1 comments

Hi Pelle,

The latest version of jUnidecode has been pushed to Maven, so I figured I'd give pulling it in a go.

I've had to change a few tests, which I think is because jUnidecode works differently. Unfortunately, with Sourceforge being down I can't find out if this is an expected change (it's surprising given it's only a patch change).

All the best,

James

jcf avatar Feb 18 '15 10:02 jcf

@jcf I just stumbled on all of this...late to the party!

your test changes are failing for me (I realize this is over a year old). Just throwing it out there incase this can get merged and updated on clojars etc. :)

> lein test

lein test slugger.conversions-test

lein test :only slugger.conversions-test/unidecode-test

FAIL in (unidecode-test) (conversions_test.clj:7)
expected: (= (unidecode "Brændgård vil have øl i grünefeldt") "Braendgard vil have ol i grunefeldt")
  actual: (not (= "Braendgaard vil have oel i gruenefeldt" "Braendgard vil have ol i grunefeldt"))

lein test slugger.core-test

lein test :only slugger.core-test/slug-tests

FAIL in (slug-tests) (core_test.clj:10)
expected: (= (->slug "Vi vil have mere øl") "vi-vil-have-mere-ol")
  actual: (not (= "vi-vil-have-mere-oel" "vi-vil-have-mere-ol"))

Ran 5 tests containing 62 assertions.
2 failures, 0 errors.
Tests failed.

Reverting the last commit containing the test changes fixes things for me.

webmonarch avatar Jun 07 '16 01:06 webmonarch