cloth icon indicating copy to clipboard operation
cloth copied to clipboard

Upgrade for solc 0.4.16 and TestRPC v4.1.3

Open craig-ludington opened this issue 8 years ago • 0 comments

  • Solc
    • The format of the JSON emitted by solc changed between version 0.4.1 and 0.4.16. The keys for contracts used to be the contract name but now they include the file name. Old: "SimpleToken", new: "path/to/SimpleToken:SimpleToken".
    • cloth.contracts/compile-solidity accepts the newer version of solc JSON output
    • The new version of compile-solidity accepts solc 0.4.1 output as well as 0.4.16 output.
    • There's an optional compile-solidity argument, ignore-warnings? that treats the compilation as successful when there are warnings but solc exit status is zero. If solc returns a non-zero status, compile-solidity fails either way.
  • TestRPC
    • The default testrpc gasPrice is very large (20000000000) which caused many test failures. Some failed due to out-of-gas errors. Others failed because they explicitly tested for gasPrice of 1.
    • Starting TestRPC with --gasPrice 1 allows the tests to pass.

craig-ludington avatar Oct 12 '17 15:10 craig-ludington