imdbphp 2 no longer pulling all information

[underslung]

I noticed recent additions weren't pulling images so I went to check for an imdbphp update and found it's been restructured. It's easy to move from v2 to v3, though. Download and extract it into ./lib/site and symlink imdbphp2 to it, then change this in imdbphp.class.php:

//include_once("./lib/site/imdbphp2/imdb.class.php"); //include_once("./lib/site/imdbphp2/imdbsearch.class.php"); include_once("./lib/site/imdbphp2/bootstrap.php");

Then at line 118 change imdb to \Imdb\Title :

                    $imdb = new \Imdb\Title($search_attributes_r['imdb_id']);

[pellcorp]

Can you create a pull request with this change. I can then merge from ui

[underslung]

Yeah, I will when I look at it a bit more, this isn't really a complete solution, just got me up and running. How relevant is the imdb.config.php file these days? It also references an old class and is just getting ignored. I edited Config.php in the new imdbphp directly.

[pellcorp]

If its ignored it sounds fine to delete it.

[pellcorp]

Did you get anywhere with this I never saw an mr

[underslung]

I mostly forgot about it. I'll try and take a look tomorrow. Whatever I ended up doing works, I've upgraded imdbphp several times with no issues.

On Oct 17, 2017, at 5:50 PM, Jason Pell [email protected] wrote:

Did you get anywhere with this I never saw an mr

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/pellcorp/opendb","title":"pellcorp/opendb","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/pellcorp/opendb"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pellcorp in #89: Did you get anywhere with this I never saw an mr"}],"action":{"name":"View Issue","url":"https://github.com/pellcorp/opendb/issues/89#issuecomment-337399331"}}}

[pellcorp]

If we can avoid soft links and just copy imdbphp into the lib for. Opendb is windows compatible so no soft link

[pellcorp]

Did you make progress with this

[pellcorp]

You could clone this repo Then copy your changes over top of that checked out workspace and that should give you most of the changes required for a Mr.