minecraft icon indicating copy to clipboard operation
minecraft copied to clipboard

Update egg-curse-forge-generic.json to support CurseForge API changes

Open dhkatz opened this issue 9 months ago • 8 comments

Description

CurseForge made some weird changes to their API requiring me to update the response parsing a bit.

As always I also publish my scripts in a human readable form here:

https://gist.github.com/dhkatz/edfa7f2efd6f819d0884760602daadd8#file-curseforge-sh

Checklist for all submissions

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Have you tested and reviewed your changes with confidence that everything works?
  • [x] Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • [x] You verify that the start command applied does not use a shell script
    • [x] If some script is needed then it is part of a current yolk or a PR to add one
  • [x] The egg was exported from the panel

dhkatz avatar Mar 25 '25 00:03 dhkatz

In case this gets approved quickly, can we hold off on merging? I want a couple users to test I know were having issues, in case this doesn't fix it I will need to make more changes

dhkatz avatar Mar 25 '25 00:03 dhkatz

In case this gets approved quickly, can we hold off on merging? I want a couple users to test I know were having issues, in case this doesn't fix it I will need to make more changes

let me know if someone external has verified this

QuintenQVD0 avatar Mar 29 '25 08:03 QuintenQVD0

@QuintenQVD0 I tried this earlier tonight and still seem to be getting errors when trying to install RLCraft via the egg. Seems maybe still be an API issue from Curse forge?

pelican@RLCraft ~ Server marked as offline...
        Running apt install
Retrieving CurseForge project information...
        ERROR: Failed to retrieve project data for project id '285109'

jlengelbrecht avatar Apr 23 '25 05:04 jlengelbrecht

I also just get

Retrieving CurseForge project information...
        No file ID specified, using latest file
parse error: Invalid string: control characters from U+0000 through U+001F must be escaped at line 3, column 32
parse error: Invalid string: control characters from U+0000 through U+001F must be escaped at line 3, column 32
        WARNING: File id '6367169' is not a server pack, attempting to use client files
        Retrieving version information for '6367169'

Get this on any modpack. Specifically, trying to use BetterMC

Exonical avatar Apr 27 '25 20:04 Exonical

@QuintenQVD0 @dhkatz For me it fails to install neoforge:

Installing required packages...
	Running apt update
	Running apt install
Retrieving CurseForge project information...
	No file ID specified, using latest file
	Found server pack file id '6502782'
	Retrieving version information for '6502782'
	Parsing CurseForge pack download url
	Downloading https://edge.forgecdn.net/files/6502/782/ServerFiles-2.47.zip
Retrieving loader information...
	Retrieving file information for '6502777'
	Parsing CurseForge pack download url
	Downloading https://edge.forgecdn.net/files/6502/777/All%20the%20Mods%2010-2.47.zip
	Unpacking client manifest
	Parsing client manifest
	Found loader neoforge 21.1.168 for Minecraft 1.21.1
Unpacking server files...
	Unpacking server.zip to /mnt/server
	Creating temporary directory
	Unpacking archive
	Setting glob settings
	Cleaning up directory structure
	Copying files to /mnt/server
Copying overrides...
Downloading NeoForge...
	Using existing NeoForge Installer 21.1.168
	Installing NeoForge Server 1.21.1 21.1.168
/mnt/install/install.sh: line 347:   384 Killed                  java -jar "neoforge-${NEOFORGE_VERSION}-installer.jar" --installServer > /dev/null 2>&1
	ERROR: Failed to install NeoForge Server 1.21.1 21.1.168
	

Serph91P avatar May 17 '25 12:05 Serph91P

Killed usualy means ran out of memory or disk space.

QuintenQVD0 avatar May 17 '25 12:05 QuintenQVD0

Killed usualy means ran out of memory or disk space.

Thank you for the quick response. Would have to check why. Because the system has 240gb space left and roughly 40gb of memory left.

Serph91P avatar May 17 '25 12:05 Serph91P

Killed usualy means ran out of memory or disk space.

Looks like you have to speciy the ram amount Unlimited did not work, after I changed it to something specific it worked.

Serph91P avatar May 17 '25 12:05 Serph91P

Script works on my instance. 👍

DOCKER_IMAGE = ghcr.io/parkervcp/yolks:java_8
PROJECT_ID = 256183
VERSION_ID = 3302998
# https://www.curseforge.com/minecraft/modpacks/ftb-presents-skyfactory-3/files/3302998

DaNussi avatar Dec 13 '25 16:12 DaNussi

@dhkatz Please resolve the merge conflict

QuintenQVD0 avatar Dec 14 '25 10:12 QuintenQVD0