minecraft icon indicating copy to clipboard operation
minecraft copied to clipboard

Zenith Proxy

Open Veslydev opened this issue 9 months ago • 9 comments

Description

Checklist for all submissions

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Have you tested and reviewed your changes with confidence that everything works?
  • [x] Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • [ ] You verify that the start command applied does not use a shell script
    • [ ] If some script is needed then it is part of a current yolk or a PR to add one
  • [ ] The egg was exported from the panel

New egg Submissions

  1. [x] Does your submission pass tests (server is connectable)?
  2. [ ] Does your egg use a custom docker image?
    • [ ] Have you tried to use a generic image?
    • [ ] Did you PR the necessary changes to make it work?
  3. [x] Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. [x] Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. [ ] You verify that the start command applied does not use a shell script
    • [ ] If some script is needed then it is part of a current yolk or a PR to add one
    • Reason The launcher in linux just has a runnable and its using that
  6. [x] The egg was exported from the panel

Veslydev avatar Mar 23 '25 17:03 Veslydev

(the edit reason i put spaces to the testing stage and forgot to remove it now i seen it)

Veslydev avatar Apr 02 '25 08:04 Veslydev

I fixed in #9dcbcdf and #0b8dd78 for pterodactyl tested on pelican demo and my own server idk if pelican demo is aarch but amd64 works fine @QuintenQVD0

Veslydev avatar Apr 02 '25 15:04 Veslydev

@QuintenQVD0 hey are you alive?

Veslydev avatar Apr 05 '25 06:04 Veslydev

@QuintenQVD0 hey are you alive?

Can you not do that? Reviews will happen when I have time.

QuintenQVD0 avatar Apr 05 '25 07:04 QuintenQVD0

@QuintenQVD0 hey are you alive?

Can you not do that? Reviews will happen when I have time.

okay sorry

Veslydev avatar Apr 05 '25 07:04 Veslydev

its been 2 months, anybody?

Veslydev avatar Jun 26 '25 09:06 Veslydev

its been 2 months, anybody?

its been 2 months, anybody?

Did you fix my requested changes? no so no new revieuw will happen

QuintenQVD0 avatar Jun 26 '25 10:06 QuintenQVD0

Yes i did on #9dcbcdf and #0b8dd78 comit and i requested review and you said you are busy and cloudn't check it

Veslydev avatar Jun 26 '25 10:06 Veslydev

https://github.com/pelican-eggs/minecraft/pull/65/commits/9dcbcdf291aab2faeb026165d45fa4c8bb8ea1de https://github.com/pelican-eggs/minecraft/pull/65/commits/0b8dd789df550d842269fc0294b223a787839274

Veslydev avatar Jun 26 '25 11:06 Veslydev