minecraft icon indicating copy to clipboard operation
minecraft copied to clipboard

changed all images from openjdk:8-jdk-slim to eclipse-temurin:8

Open DaNussi opened this issue 1 month ago • 8 comments

Description

This PR resolves #98. I have gone ahead and replaced all occurrences of openjdk:8-jdk-slim with eclipse-temurin:8. This should be a drop-in replacement. I have only tested the Curseforge Generic egg; let me know if further testing is required. 😄

Checklist for all submissions

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] Have you tested and reviewed your changes with confidence that everything works?
  • [x] Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • [ ] You verify that the start command applied does not use a shell script
    • [ ] If some script is needed then it is part of a current yolk or a PR to add one
  • [x] The egg was exported from the panel

DaNussi avatar Nov 18 '25 00:11 DaNussi

We have pelican managed java install images now.

You can use either of the following. Each has a reason to be there. Some newer mc version will require java 17 to build properly.

ghcr.io/pelican-eggs/installers:java_8
ghcr.io/pelican-eggs/installers:java_17

parkervcp avatar Nov 18 '25 01:11 parkervcp

Egg's that need Testing:

  • [ ] Curse Forge Generic
  • [ ] Curse Forge Generic Pterodactyl
  • [ ] Fabric
  • [ ] Fabric Pterodactyl
  • [ ] Forge Enhanced
  • [ ] Forge Enhanced Pterodactyl
  • [ ] FTB Server
  • [ ] FTB Server Pterodactyl
  • [ ] Glowstone
  • [ ] Glowstone Pterodactyl
  • [ ] Modrinth Generic
  • [ ] Modrinth Generic Pterodactyl
  • [ ] Quilt
  • [ ] Quilt Pterodactyl
  • [ ] Sponge Forge
  • [ ] Sponge Forge Pterodactyl
  • [ ] Vanilla Cord
  • [ ] Vanilla Cord Pterodactyl

DaNussi avatar Nov 18 '25 12:11 DaNussi

Have you done a find for the openjdk images on all the eggs yet? I feel like this is missing many that will need to be updated. I am certain Fabric is on the list as I have tested that locally

parkervcp avatar Nov 18 '25 14:11 parkervcp

@DaNussi Can you please check for other eggs that use the old images as well please.

parkervcp avatar Nov 24 '25 13:11 parkervcp

@parkervcp can do, but it's going to take some time i am currently bussy with university 😆

DaNussi avatar Nov 26 '25 19:11 DaNussi

@DaNussi we only have installer images for Java 8 and 17.

You would use either of these

ghcr.io/pelican-eggs/installers:java_8 ghcr.io/pelican-eggs/installers:java_17

parkervcp avatar Dec 01 '25 18:12 parkervcp

@DaNussi we only have installer images for Java 8 and 17.

You would use either of these

ghcr.io/pelican-eggs/installers:java_8 ghcr.io/pelican-eggs/installers:java_17

For some eggs i need the java-21 installer. Should i create a PR in https://github.com/pelican-eggs/yolks that adds it or is there an alternative like using ghcr.io/parkervcp/yolks:debian and manualy installing java-21 ?


and isn't the image tag ghcr.io/parkervcp/installers:java_8 and not ghcr.io/pelican-eggs/installers:java_8? If no where do i find the repo for the ghcr.io/pelican-eggs images?

DaNussi avatar Dec 02 '25 11:12 DaNussi

I created a PR to add the installers. pelican-eggs/yolks#337

DaNussi avatar Dec 02 '25 13:12 DaNussi

A note. The pelican-eggs/yolks and parkervcp/yolks images are identical.

Do we think this is good to go @QuintenQVD0 ?

parkervcp avatar Dec 16 '25 17:12 parkervcp