pelican-eggs
Update arma reforger
Description
- Set a default addonTempDir
- closes #2879
Checklist for all submissions
- [x] Have you followed the guidelines in our Contributing document?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
- [x] Have you tested and reviewed your changes with confidence that everything works?
- [x] Did you branch your changes and PR from that branch and not from your master branch?
- If not, why?:
- [x] You verify that the start command applied does not use a shell script
- [ ] If some script is needed then it is part of a current yolk or a PR to add one
- [x] The egg was exported from the panel
https://github.com/parkervcp/eggs/issues/2879 implies only the startup flag needs to be added to resolve the issue. If the Arma server can automatically create the missing folder, I don't think we need to adjust the install script. Also, I don't think we need a variable for the folder location. I would just hardcode it into the startup command personally (that way an end-user doesn't accidentally put it in a reserved folder that somehow breaks things).
This will need testing either way to make sure it works. If arma can create the folder on its own then a hard coded value in the startup should be fine but a company may want it configurable to match mounts they have configured.
a company may want it configurable to match mounts they have configured
But it's a temp/throwaway folder just for downloading, no? Why would you assign it to a mount? Only reason I can think of would be to give free space other than what is allocated.
a company may want it configurable to match mounts they have configured
Why would you assign it to a mount? Only reason I can think of would be to give free space other than what is allocated.
I can think of many reasons. They could mount to hdd based storage instead of ssd based to save on writes to the disk and have the disks last longer.
I also argue for more configurable when possible.
That's fair. I also just realized the variable is not user-editable, which works for me 👍