eggs icon indicating copy to clipboard operation
eggs copied to clipboard

Published 20 hours ago • verified publisher icon pelican-eggs

Update magma egg

Open JustRed23 opened this issue 2 years ago • 4 comments

Description

Add support for the recently released 1.18 server jar. This also removes some unnecessary future proofing

Checklist for all submissions

  • [X] Have you followed the guidelines in our Contributing document?
  • [X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [X] Have you tested and reviewed your changes with confidence that everything works?
  • [X] Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

JustRed23 avatar Aug 14 '22 23:08 JustRed23

Should be good now. The only problem i have with this script is that the latest version behaves a little weird. It never checks if there is a server jar so when you use latest and the latest version is 1.18.2 it will try to run the installer jar method and fail. So you will have to set the version manually instead of setting it to latest

JustRed23 avatar Aug 14 '22 23:08 JustRed23

I am not experienced with bash enough to fix this

JustRed23 avatar Aug 14 '22 23:08 JustRed23

Should be good now. The only problem i have with this script is that the latest version behaves a little weird. It never checks if there is a server jar so when you use latest and the latest version is 1.18.2 it will try to run the installer jar method and fail. So you will have to set the version manually instead of setting it to latest

That's because you're checking if MC_VERSION is latest or not set to run the installer.

I've refactored a lot of the old code while reviewing it, but can't really finish as the installer hosts have outdated sources for required dependencies at the time of this comment. This makes testing the installer impossible.

What all versions currently have a custom bundled magma jar instead of relying on Forge UNIX args? According to my quick test and API results, all of them currently have a jar and don't need the installer.

I'll try to run through all the jars later and drop the installer completely for current known versions if they indeed have a jar.

Software-Noob avatar Aug 16 '22 13:08 Software-Noob

Yea the current versions all support the server jar, the installer jar is kind of obsolete now.

JustRed23 avatar Aug 16 '22 20:08 JustRed23

This shoud already be fixt by: https://github.com/parkervcp/eggs/pull/1882

QuintenQVD0 avatar Oct 01 '22 09:10 QuintenQVD0