panel icon indicating copy to clipboard operation
panel copied to clipboard

Added footer & small improvments

Open Poseidon281 opened this issue 1 year ago • 5 comments

Poseidon281 avatar May 17 '24 18:05 Poseidon281

I'm able to reproduce this issue with the nQuakesv package.

server log when calling /1on1. k_pow is 0 as expected

1 on 1 settings enabled by FU-rusti
execing configs/usermodes/default.cfg
execing configs/usermodes/1on1/default.cfg

matchtag not set
] k_pow
"k_pow" is "0"

and then /hoonymode. Note: 1on1/default.cfg is not executed. k_pow is 1

HoonyMode settings enabled by FU-rusti
execing configs/usermodes/default.cfg

matchtag not set
] k_pow
"k_pow" is "1"

When I look at default configs I can see following k_pow values. usermodes/default.cfg

set k_pow 1

usermodes/1on1/default.cfg

set k_pow 0

mikraj01 avatar May 05 '23 19:05 mikraj01

when is this getting attention? its annoying and should be an easy fix.

mushis avatar Aug 08 '23 22:08 mushis

I guess this means its not a server config issue, but rather a code issue.

mushis avatar Aug 09 '23 10:08 mushis

Upon activating /hooneymode, first we apply the content of '_1on1hm_um_init', followed by executing ktx/configs/usermodes/default.cfg.

This default.cfg in the nquakesv installer contains 'k_pow 1' (see https://github.com/nQuake/distfiles/blob/master/sv-configs/ktx/configs/usermodes/default.cfg).

I think the easiest fix is to make the change in the nquakesv, and remove k_pow from the default.cfg, instead of diving into the execution order of these config files upon executing a usermode command like /hooneymode, or /1on1. I guess every mode where powerups are required (2on2, 4on4, etc) have 'k_pow 1' defined in the dedicated 'default.cfg' file, so removing it from the top-level default.cfg will do no harm.

tcsabina avatar Aug 12 '23 23:08 tcsabina

I've just made a PR to update the default.cfg in the nquakesv package. Let's see...

tcsabina avatar Aug 12 '23 23:08 tcsabina