panel icon indicating copy to clipboard operation
panel copied to clipboard

Server search freezes page

Open m41denx opened this issue 1 month ago • 8 comments

Current Behavior

When you attempt to search servers in user panel, if server is found the whole page "freezes" - no buttons can be pressed, and also server cards are empty

Image

Expected Behavior

Search works and displays matching servers

Steps to Reproduce

Reproducible on Pelican demo, as well as standalone installation

Panel Version

canary

Wings Version

not relevant

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs


Is there an existing issue for this?

  • [x] I have searched the existing issues before opening this issue.
  • [x] I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • [x] I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

m41denx avatar Oct 31 '25 13:10 m41denx

Can confirm: Image

Reloading the page works, so maybe a SPA issue?

Boy132 avatar Oct 31 '25 13:10 Boy132

Just spotted an additional issue with search in admin panel

SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'name' in WHERE is ambiguous (Connection: mariadb, SQL: select count(*) as aggregate from `servers` left join `nodes` on `servers`.`node_id` = `nodes`.`id` where `node_id` in (1) and (`name` like %ddfj% or exists (select * from `eggs` where `servers`.`egg_id` = `eggs`.`id` and `name` like %ddfj%) or exists (select * from `users` where `servers`.`owner_id` = `users`.`id` and `username` like %ddfj%))) (View: /var/www/pelican/vendor/filament/tables/resources/views/index.blade.php) (View: /var/www/pelican/vendor/filament/tables/resources/views/index.blade.php)
                       

Search just straight up doesnt work and errors with 500

m41denx avatar Oct 31 '25 13:10 m41denx

Btw I'll investigate bug with admin area search, but not Livewire lol (i have no idea how it works or hydrates page)

m41denx avatar Oct 31 '25 13:10 m41denx

@Boy132 would this fix the issue with admin panel? I just don't know how column names are used in templates

Subject: [PATCH] Would this fix the issue?
---
Index: app/Filament/Admin/Resources/Servers/Pages/ListServers.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/Filament/Admin/Resources/Servers/Pages/ListServers.php b/app/Filament/Admin/Resources/Servers/Pages/ListServers.php
--- a/app/Filament/Admin/Resources/Servers/Pages/ListServers.php	(revision fb9a171b851496dc400563060ba4028b4a4790d7)
+++ b/app/Filament/Admin/Resources/Servers/Pages/ListServers.php	(date 1761916854852)
@@ -45,7 +45,7 @@
                     ->hidden()
                     ->label('UUID')
                     ->searchable(),
-                TextColumn::make('name')
+                TextColumn::make('server.name')
                     ->label(trans('admin/server.name'))
                     ->searchable()
                     ->sortable(),

m41denx avatar Oct 31 '25 13:10 m41denx

It's because of view caching. When running php artisan optimize:clear (or just php artisan view:clear) it works.

Boy132 avatar Oct 31 '25 13:10 Boy132

Just spotted an additional issue with search in admin panel

SQLSTATE[23000]: Integrity constraint violation: 1052 Column &#039;name&#039; in WHERE is ambiguous (Connection: mariadb, SQL: select count(*) as aggregate from `servers` left join `nodes` on `servers`.`node_id` = `nodes`.`id` where `node_id` in (1) and (`name` like %ddfj% or exists (select * from `eggs` where `servers`.`egg_id` = `eggs`.`id` and `name` like %ddfj%) or exists (select * from `users` where `servers`.`owner_id` = `users`.`id` and `username` like %ddfj%))) (View: /var/www/pelican/vendor/filament/tables/resources/views/index.blade.php) (View: /var/www/pelican/vendor/filament/tables/resources/views/index.blade.php)
                       

Search just straight up doesnt work and errors with 500

That should be a separate issue. (or just create a PR with a fix)

Boy132 avatar Oct 31 '25 13:10 Boy132

@Boy132 I've had this issue as well, I have to refresh two or three times and then the console log will populate.

NerdsCorp avatar Oct 31 '25 17:10 NerdsCorp

Still not fixed.

Boy132 avatar Nov 15 '25 13:11 Boy132