panel icon indicating copy to clipboard operation
panel copied to clipboard

HTTPS with (reverse) proxy should not change wings port

Open SteadEXE opened this issue 7 months ago • 4 comments

Current Behavior

I have Wings configured to serve on port 8080 but publicly accessible on HTTPS behind a reverse proxy. To allow panel to interact with wings I had to set "HTTPS with (reverse) proxy" and port "443".

Image

But if I update something else, it overwrite port of wings setting it to listen on port 443.

Expected Behavior

There is something misleading in the configuration, public facing endpoint and private endpoint should be separate, otherwise the reverse proxy is very limited.

Maybe add an additional input.

It should ask for the actual listening port, and the publicly accessing port, which can, of course, be the same if no reverse proxy is involved.

Steps to Reproduce

Configure Wing to listen on port 8080 and then change it to "HTTPS with (reverse) proxy" on port "443"

Panel Version

v1.0.0-beta21

Wings Version

v1.0.0-beta13

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs


Is there an existing issue for this?

  • [x] I have searched the existing issues before opening this issue.
  • [x] I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • [x] I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

SteadEXE avatar May 13 '25 13:05 SteadEXE

I had the same problem when configuring Pelican Panel and this confused me. I finally fixed the problem by manually changing the API port to 8080 in the Wing's config.yml

Bulgus avatar May 14 '25 17:05 Bulgus

I did the same, but you need to be careful to not change anything else on the panel, otherwise it overwrite the port

SteadEXE avatar May 14 '25 17:05 SteadEXE

I did the same, but you need to be careful to not change anything else on the panel, otherwise it overwrite the port

FYI, you can disable the automatic panel overwrites in the wings config file.

Boy132 avatar May 15 '25 10:05 Boy132

https://github.com/pelican-dev/panel/pull/1263#issuecomment-2814254635

If we add this back i think we should also add a reverse proxy port field that would be what the user uses to contact wings & daemon_listen that would be the port used to communicate between wings & the reverse proxy so you don't have to manually edit the config.yml So being split makes more sense to me

We could also add a ToggleButton to not sync updates from the panel by setting ignore_panel_config_updates in $node->getConfiguration()

rmartinoscar avatar May 16 '25 22:05 rmartinoscar