parser icon indicating copy to clipboard operation
parser copied to clipboard

feat: add new StreetNumericClassification

Open JanF01 opened this issue 1 year ago • 1 comments

:wave: I thought about how to solve #175 . I came up with adding a new StreetNumericClassification. I'm aware that it is a very country specific case.


Here's the reason for this change :rocket:

As stated in #175, Poland has a lot of Street Names that start with numbers, we have found over a 1500 such streets in the database and just creating schemes for them is not a possibility as the 2nd, 3rd and so on words should be classified accordingly. I would be open for any different ideas to solving this issue.


Here's what actually got changed

  • [x] Added StreetNumericClassification and StreetNumericClassifier
  • [x] Added numeric_streets.txt to the pelias dictionary with keywords that in most cases begin a Numeric Street
  • [x] Added schemes for Numeric Streets with 1,2,3 or 4 word length

Here's how others can test the changes :eyes:

I have added unit tests for the StreetNumericClassifier

Closes #175

JanF01 avatar Aug 18 '23 08:08 JanF01

@missinglink @Joxit I would appreciate your insights on whether the proposed solution is suitable for inclusion or if it requires revisions. Thank you for your time

JanF01 avatar Sep 04 '23 09:09 JanF01