parser icon indicating copy to clipboard operation
parser copied to clipboard

Updated some german abbreviations & added support for fractional housenumbers

Open arnesetzer opened this issue 2 years ago • 2 comments

:wave: I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change :rocket:

  • [X] Got a project with these type of housenumbers
  • [X] Other project, where "bei Berlin" (near Berlin) won't be found caused by the name "b.Berlin"

Here's what actually got changed :clap:

  • [x] Added some german abbreviations
  • [x] Added support for fricitonal housenumber appendix like "3 1/4". Didn't knew that this was a thing until I got hands on this project. Examples:
  • https://www.openstreetmap.org/way/207516185
  • https://www.openstreetmap.org/way/207516186
  • https://www.openstreetmap.org/way/319538694
  • https://www.openstreetmap.org/way/173507661

Here's how others can test the changes :eyes:

Import the german osm data and try to find these buildings by their address. As far as I concerned these are written down correctly in OSM

arnesetzer avatar Jun 21 '22 06:06 arnesetzer

hi @arnesetzer there is an issue running CI for external contributors. I hopefully have it fixed in https://github.com/pelias/parser/pull/160

Please rebase master against your branch and push to trigger the CI

missinglink avatar Jun 21 '22 12:06 missinglink

@arnesetzer the unit tests are failing, you can run them locally with the command npm test

missinglink avatar Aug 17 '22 13:08 missinglink