api icon indicating copy to clipboard operation
api copied to clipboard

only translate name.default when translation is same source and source_id

Open missinglink opened this issue 4 years ago • 1 comments

The middleware/changeLanguage.js code is a little too liberal when replacing the name.default with a translation. Prior to this PR the code replaces name.default without first checking the source and source_id.

note: I struggled a bit to read and write this code, requires a second set of 👀

missinglink avatar Aug 17 '21 12:08 missinglink

I think we talked about this the other day, but can you provide some more details and background here regarding the issue at hand, maybe some test cases, etc? It will be good to have for reference in the future.

orangejulius avatar Aug 18 '21 17:08 orangejulius