pelias
discuss: duplicate `id` property in geojson
we have a property called id in the geojson which appears to be a dupe of source_id
would it be possible to deprecate and remove one of these two properties?
Deprecating properties from the GeoJSON response that comes from Pelias would be hard and painful, I don't think we have a good process around it, and it might not be too valuable.
However we should definitely remove the underlying data duplication, which is tracked in https://github.com/pelias/schema/issues/383
I was sitting with someone recently who was new to Pelias, they were using React, which requires a unique key to render a list of items (so it can correctly track state changes).
He naturally assumed that id was the correct field to use for this purpose but was later confused why fewer results were being rendered in React than were provided in the raw geojson response.
What was happening here was that the results contained both a venue and an address from the same OSM source ID and so keying the data using id was removing one of the two disparate records
I think you're right that completely removing the field could easily break integrations but it's still unintuitive as-is, maybe we can resolve this by having id as a duplicate of the gid field instead of the source_id field?